-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tools] Implement lorisInstance in tools directory #9397
base: main
Are you sure you want to change the base?
[tools] Implement lorisInstance in tools directory #9397
Conversation
@victori444 Assigning to you to resolve conflicts and then I'll test / review! |
does this resolve the issue listed or only partially resolve it? (There are many places listed in the issue and merging it with "Resolved" will close the issue automatically) |
According to the comments of the issue, these were the only 2 remaining out of the initial list |
4b6a810
to
11e3717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -84,7 +84,6 @@ | |||
JOIN candidate c ON c.CandID=s.CandID | |||
JOIN test_names tn ON tn.ID=f.TestID | |||
WHERE c.Active='Y' AND s.Active='Y' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing just a whitespace change here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting this error when running:
(base) lorisadmin@cbeaudoin-dev:/var/www/loris/tools$ php detect_conflicts.php -r all -y
Array
(
[r] => all
[y] =>
)
Removing ignored conflictsPHP Fatal error: Uncaught Error: Cannot use object of type LORIS\Database\Query as array in /var/www/loris/tools/detect_conflicts.php:595
Stack trace:
#0 /var/www/loris/tools/detect_conflicts.php(146): detectIgnoreColumns()
#1 {main}
thrown in /var/www/loris/tools/detect_conflicts.php on line 595
@@ -84,7 +84,6 @@ | |||
JOIN candidate c ON c.CandID=s.CandID | |||
JOIN test_names tn ON tn.ID=f.TestID | |||
WHERE c.Active='Y' AND s.Active='Y' | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing just a whitespace change here
588142f
to
15fa08b
Compare
Hm I don't get this error - I think this may be the error that the PR changes resolve since line 595 in the current script is where |
Brief summary of changes
Implements lorisInstance in detect_conflicts.php
Resolves other errors found in detect_conflicts.php & fix_candidate_age.php (accessing $commentIDs as an array & querying Test_name)
Have you updated related documentation?
Testing instructions (if applicable)
Link(s) to related issue(s)