Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue_tracker] Enable editing of site, assignee and watchers in Batch Mode #9425

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

ay-bh
Copy link
Collaborator

@ay-bh ay-bh commented Oct 26, 2024

Brief summary of changes

  • Added site selector to Issue Card edit mode
  • Enhanced Add Comment modal with assignee and watchers selectors
  • Updated backend endpoint to fetch otherWatchers and assignees

Testing instructions

  1. Go to Issue Tracker Batch Mode
  2. Click "Edit Issue" on any issue
  3. Verify site can be modified using the new dropdown
  4. Update Issue
  5. Click "Add Comment"
  6. Verify assignee and watchers can be modified in the modal
  7. Submit changes and verify they persist

Link(s) to related issue(s)

Screenshots

image image

@christinerogers
Copy link
Contributor

@ay-bh if this is ready for review -- please request review from @regisoc and @racostas

@ay-bh ay-bh requested a review from regisoc October 28, 2024 18:27
@ay-bh ay-bh force-pushed the feature-batch-mode-enhancements branch from 44f42e9 to 5741cbc Compare October 29, 2024 19:42
Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, comments:

  • Some static test did not pass.
  • adding/removing watchers looks good and in sync when switching from edit/detail view to batch mode.
  • site dropdown, I tried to change to No Site but had the following image show up.
    This option should not be added to force user to choose one site.

image

  • issue: unassigned state card text. When no assignee or unassigning someone from an issue, there is a blank in the card. This should instead have an explicit "unassigned" tag. Also, on a second thought, it is in line with the previous comment, not allowing to have a ticket unassigned might be a good idea. The goal of issue tracker is to resolve those tickets. Not having someone assigned, they will be forgotten.

image

  • issue maybe? @racostas I think it is not linked to this PR: when updating the assignee, no history about this change in the edit/detailed view. The change is acted on the batch mode card view, and in the edit/detailed view but not in the history section.

image

@ay-bh ay-bh force-pushed the feature-batch-mode-enhancements branch from 5741cbc to 1bff72c Compare November 2, 2024 14:52
@ay-bh ay-bh requested a review from regisoc November 2, 2024 14:53
@racostas racostas added the Event: GSOC PR or issue accepted for Google Summer of Code label Nov 3, 2024
Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @ay-bh :

  • No site issue: is ok, option removed.
  • Unassigned Issue : states Assignee:None in card. Front-end looks ok. I am scratching my head here as I see it as mandatory as the previous point. In HBCD, we enforced a default assignee based on category so that issues do not fall into limbo. @christinerogers @racostas does that make sense to you that an issue is not assigned?
  • no assignee update in history issue: could/should be referenced in another issue ticket if necessary.

@racostas @christinerogers If the second point is ok to you, then the PR looks ok to me.

@christinerogers
Copy link
Contributor

christinerogers commented Nov 7, 2024

Thanks @regisoc for these comments.
from the bottom up:

  • no assignee update in history issue: could/should be referenced in another issue ticket if necessary.

Agree this should be another issue, and it's important. I'll add this to the Followup ticket #9418. @ay-bh if you feel keen to address this on your own time, thank you - it's optional since you have completed GSOC.

  • No site issue: is ok, option removed.
  • Unassigned Issue : states Assignee:None in card.

@regisoc I get why HBCD has customized this module to make assignee and site selection mandatory, and there are valid reasons these were not mandatory in the Loris module design.
Let's leave this as it is currently, keep the no-site enforcement change, and I'll add a follow up point in #9418 to make both of these configurable parameters.

@racostas @christinerogers If the second point is ok to you, then the PR looks ok to me.

Agreed let's proceed with this PR as is. Over to @racostas for review to move this PR forward.

Note this no-site design change requested by regis should be documented in the module readme, and this is one of many points to follow up on in #9418

@regisoc
Copy link
Contributor

regisoc commented Nov 12, 2024

@racostas waiting for your review, I will put you as assignee.

Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I reviewed all again and manual tested:

  • Functionalities looks good.
  • Assignee not been updated in history I checked and effectively is a preexisting issue. I agree we should tackle this. Yes, let's create an issue for it ... or we can added it to [issue_tracker] batch mode - follow up #9418 since this look a very good summary ticket for all issue_tracker related developments. Do you think this could be a good idea @regisoc ?
  • Regarding making the assignee mandatory, I don't have a super strong opinion, I see for example in Redmine is not mandatory, but something we can think about it. It could be a new point in [issue_tracker] batch mode - follow up #9418 as well.

In conclusion, I think this PR is good to go. I leave @driusan the final review / approval.

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Nov 18, 2024
@racostas
Copy link
Contributor

I saw the two point were already added to #9418 :)
All good !

@driusan driusan merged commit 452218c into aces:main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: GSOC PR or issue accepted for Google Summer of Code Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants