[issue_tracker] Convert batch/normal mode toggle to tabs and implement permission control #9434
Conversation
There was a problem hiding this comment.
lgtm but did not pull/test. thanks for taking care of this so quickly Ayush
@ay-bh confirm pls this doesn't create bottlenecks by loading all the data in both tabs at once, correct?
as a future enhancement we could consider hiding the Browse Issues tab for non-developers - the vertical space use doesn't make sense if it's the only tab option for end-users. @regisoc @racostas any strong feelings here?
There was a problem hiding this comment.
Thanks @ay-bh !
- PR rebase required.
- This looks clean. I like it.
- @christinerogers Agreed, tabs should be hidden for someone not having the right permission i.e. this could be completely hidden:
ay-bh
force-pushed
the
feature-batch-mode-tab
branch
from
9c7b0fc to
a751f83
Compare
There was a problem hiding this comment.
LGTM.
- Tested with various uses/permissions looks good to me.
- The tabs yet appear when the user have only the permission "not developer" but I think this is more cosmetic and should not stop us form merging this one
What do you think @regisoc , @christinerogers ?
racostas
added
the
Passed manual tests
|
@racostas that is a cosmetic change, we can change it later. |
christinerogers
dismissed
regisoc’s stale review
addressed. @regisoc confirmed in the thread
|
3 approvals - over to @driusan for final review. |
…t permission control (aces#9434) - Replaced the view toggle button with a tabbed interface using `Tabs` component - Added permission check to show Batch Edit tab only for users with `issue_tracker_developer` permission - Implemented data refresh when switching back to Browse Issues tab #### Link(s) to related issue(s) * Resolves aces#9422, aces#9423 * Part of aces#9418
Brief summary of changes
Tabscomponentissue_tracker_developerpermissionTesting instructions
issue_tracker_developerpermission - verify only "Browse Issues" tab is visibleissue_tracker_developerpermission - verify both "Browse Issues" and "Batch Edit" tabs are visibleLink(s) to related issue(s)
developerpermission #9422, [issue_tracker] Batch mode: Button style should match LORIS #9423Screenshot