-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[instrument_manager] Parse Instrument Data from CSV file #9472
Draft
jeffersoncasimir
wants to merge
14
commits into
aces:main
Choose a base branch
from
jeffersoncasimir:2024_10_28_instrument_data_parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[instrument_manager] Parse Instrument Data from CSV file #9472
jeffersoncasimir
wants to merge
14
commits into
aces:main
from
jeffersoncasimir:2024_10_28_instrument_data_parser
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Nov 19 LORIS call:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview - not yet ready for review
Closes #9341
Brief summary of changes
Contains a new
CSVParser
class, extended by anInstrumentDataParser
class.A template file with the expected headers for the selected instrument can be downloaded from the new "Upload Instrument Data" panel's form in the Upload tab of the Instrument Manager module.
The uploaded .csv file's headers must match the selected instrument's expected headers.
For each row, an instrument is created using the
NDB_BVL_Instrument::factory
and is then saved to the database.If an error is detected, the database transaction will be rolled back, and the list of errors will be returned to the user.
Testing instructions
Screenshots:
Coming soon:
InstrumentDataParser
classTestPlan.md
Potential changes: