Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Candidate] RE-add support to create candidates from the backend (unix user) #9485

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ridz1208
Copy link
Collaborator

@ridz1208 ridz1208 commented Nov 26, 2024

Brief summary of changes

The current code tries to get a username from the session. the session does not have a state when the candidate::createnew function is called from a script on the backend.

The new code is inpired by the database class which tries to use the environment username to create the data.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. make sure you can still create a candidate with no issue the standard way
  2. try to create a candidate fro ma script in the backend

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@ridz1208 ridz1208 assigned ridz1208 and GeorgeMurad and unassigned ridz1208 Dec 9, 2024
Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 3887c03 into aces:26.0-release Dec 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants