Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flag] Fix remaining test_name flag #9486

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[flag] Fix remaining test_name flag #9486

wants to merge 2 commits into from

Conversation

skarya22
Copy link
Contributor

Brief summary of changes

  • Fix missing changes for including test_names.ID instead of Test_names from flag.

Link(s) to related issue(s)

@skarya22 skarya22 assigned skarya22 and driusan and unassigned skarya22 Nov 26, 2024
@skarya22 skarya22 added the Priority: High PR or issue should be prioritised over others for review and testing label Nov 26, 2024
@maximemulder maximemulder added Area: Instruments PR or issue related instruments Category: Bug PR or issue that aims to report or fix a bug labels Nov 29, 2024
driusan
driusan requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add brackets around the ON clauses for consistency with the rest of LORIS?

@skarya22 skarya22 requested a review from driusan December 13, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driusan driusan Awaiting requested review from driusan

Requested changes must be addressed to merge this pull request.

Assignees

@driusan driusan

Labels
Area: Instruments PR or issue related instruments Category: Bug PR or issue that aims to report or fix a bug Priority: High PR or issue should be prioritised over others for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flag] Remaining files referencing "Test_name" in flag table
3 participants
@skarya22 @driusan @maximemulder