Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data_release] FileUpload version permission #9489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

victori444
Copy link
Contributor

@victori444 victori444 commented Nov 28, 2024

Brief summary of changes

When uploading a new file with an existing version, users with permission to that version would be reset. This ensures users with access to the version gain permission to the new file

Testing instructions (if applicable)

  1. In Data Release, upload a new file with a new version and give a non-admin user permissions to that version in 'Manage Permissions'
  2. Upload another file under that version
  3. In 'Manage Permissions', verify that the non-admin user still has access to the version
  4. Access the data release module as the non-admin user and check that you have access to the files under that version

CCNA Override

@maximemulder maximemulder added Project: CCNA Issue or PR related to the CCNA project and removed Priority: Projects labels Nov 29, 2024
Copy link
Contributor

@shonibare shonibare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Project: CCNA Issue or PR related to the CCNA project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants