Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[publication] Fix edit PI issue #9492

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

victori444
Copy link
Contributor

Brief summary of changes

In the Publication module, when editing a PI for a project (name/email), all other projects with the same PI would be modified. This PR takes the PI's email as the PI's identifier and

  • if the email is updated to an existing email in the db, updates the name associated to the email and the project's LeadInvestigatorID
  • if the email is updated to a new email, creates a new collaborator with a new ID
  • if the email is not updated and the name is updated, updates the name associated to the email

Testing instructions (if applicable)

  1. Create new projects with different PIs
  2. Edit the PI information (name & email) in various ways and check that the projects are updated accordingly
  3. Verify in the publication_collaborator table that when an email is updated to a new email that does not exist, a new collaborator is created, and the original collaborator is not replaced in the database

CCNA Override

@maximemulder maximemulder added Project: CCNA Issue or PR related to the CCNA project Difficulty: Simple PR or issue that should be easy to implement, review, or test Category: Bug PR or issue that aims to report or fix a bug and removed Difficulty: Simple PR or issue that should be easy to implement, review, or test Priority: Projects labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug PR or issue that aims to report or fix a bug Project: CCNA Issue or PR related to the CCNA project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants