De-cluttering test printouts

- Removed unnecessary test printouts in the code - Updated vcpkgGitCommitId to ae360361a434310ffee36d84eb01c033b648fb22 in multiple workflows - Modified classify_cells function to be const
acgetchell · Oct 10, 2023 · 09d913d · 09d913d
1 parent 5eb1578
commit 09d913d
Show file tree

Hide file tree

Showing 12 changed files with 21 additions and 12 deletions.
diff --git a/.github/workflows/codecov-upload.yml b/.github/workflows/codecov-upload.yml
@@ -28,7 +28,7 @@ jobs:
       - name: Restore artifacts or setup vcpkg
         uses: lukka/run-vcpkg@v11
         with:
-          vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+          vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
       - name: Configure
         run: cmake -G Ninja -D CMAKE_BUILD_TYPE=RelWithDebInfo -D ENABLE_TESTING:BOOL=TRUE -D ENABLE_COVERAGE:BOOL=TRUE -S . -B build

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -67,7 +67,7 @@ jobs:
     - name: Restore artifacts or setup vcpkg
       uses: lukka/run-vcpkg@v11
       with:
-        vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+        vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
     - name: Configure
       run: cmake --preset=build

diff --git a/.github/workflows/linux-clang-pkgx.yml b/.github/workflows/linux-clang-pkgx.yml
@@ -27,7 +27,7 @@ jobs:
       - name: Restore artifacts or setup vcpkg
         uses: lukka/run-vcpkg@v11
         with:
-          vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+          vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
       - name: Configure
         run: cmake --preset=build

diff --git a/.github/workflows/linux-clang.yml b/.github/workflows/linux-clang.yml
@@ -27,7 +27,7 @@ jobs:
       - name: Restore artifacts or setup vcpkg
         uses: lukka/run-vcpkg@v11
         with:
-          vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+          vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
       - name: Configure
         run: cmake --preset=build

diff --git a/.github/workflows/linux-gcc.yml b/.github/workflows/linux-gcc.yml
@@ -27,7 +27,7 @@ jobs:
       - name: Restore artifacts or setup vcpkg
         uses: lukka/run-vcpkg@v11
         with:
-          vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+          vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
       - name: Configure
         run: cmake --preset=build

diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -19,7 +19,7 @@ jobs:
     - name: Restore artifacts or setup vcpkg
       uses: lukka/run-vcpkg@v11
       with:
-        vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+        vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
     - name: Configure
       run: cmake --preset=build

diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
@@ -31,7 +31,7 @@ jobs:
       - name: Restore artifacts or setup vcpkg
         uses: lukka/run-vcpkg@v11
         with:
-          vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+          vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
       - name: Configure
         run: cmake -G Ninja -D CMAKE_BUILD_TYPE=RelWithDebInfo -D ENABLE_TESTING:BOOL=TRUE -D ENABLE_COVERAGE:BOOL=TRUE -S . -B build

diff --git a/.github/workflows/windows-msvc.yml b/.github/workflows/windows-msvc.yml
@@ -24,7 +24,7 @@ jobs:
       - name: Restore artifacts, or setup vcpkg
         uses: lukka/run-vcpkg@v11
         with:
-          vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+          vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
       - name: Install vcpkg packages and configure CMake
         run: |

diff --git a/.github/workflows/windows-pkgx.yml b/.github/workflows/windows-pkgx.yml
@@ -24,7 +24,7 @@ jobs:
       - name: Restore artifacts, or setup vcpkg
         uses: lukka/run-vcpkg@v11
         with:
-          vcpkgGitCommitId: 7e4d2ff73b643ca2c685c6cfe0783a0f62cfb15c
+          vcpkgGitCommitId: ae360361a434310ffee36d84eb01c033b648fb22
 
       - name: Install vcpkg packages and configure CMake
         run: |

diff --git a/include/Foliated_triangulation.hpp b/include/Foliated_triangulation.hpp
@@ -836,7 +836,10 @@ namespace foliated_triangulations
           std::inserter(vertices_to_remove, vertices_to_remove.begin()),
           find_bad_vertex<dimension>);
       // Remove the vertices
-      fmt::print("There are {} invalid vertices.\n", vertices_to_remove.size());
+#ifndef NDEBUG
+      spdlog::warn("There are {} invalid vertices.\n",
+                   vertices_to_remove.size());
+#endif
       t_triangulation.remove(vertices_to_remove.begin(),
                              vertices_to_remove.end());
       assert(t_triangulation.tds().is_valid());
@@ -1493,7 +1496,7 @@ namespace foliated_triangulations
     /// @brief Classify cells
     /// @param cells The container of simplices to classify
     /// @return A container of simplices with Cell_type written to cell->info()
-    [[nodiscard]] static auto classify_cells(Cell_container const& cells)
+    [[nodiscard]] auto classify_cells(Cell_container const& cells) const
         -> Cell_container
     {
       assert(cells.size() == number_of_finite_cells());

diff --git a/tests/Foliated_triangulation_test.cpp b/tests/Foliated_triangulation_test.cpp
@@ -858,8 +858,10 @@ SCENARIO("FoliatedTriangulation_3 functions from Delaunay3" *
       {
         CHECK_FALSE(triangulation.is_initialized());
         // Human verification
+#ifndef NDEBUG
         fmt::print("Unfixed triangulation:\n");
         triangulation.print_cells();
+#endif
       }
       THEN("After being fixed, Delaunay3 functions work as expected.")
       {
@@ -883,7 +885,9 @@ SCENARIO("FoliatedTriangulation_3 functions from Delaunay3" *
         fmt::print("Base Delaunay dimension is: {}\n",
                    triangulation.dimension());
         // Human verification
+#ifndef NDEBUG
         utilities::print_delaunay(triangulation.delaunay());
+#endif
       }
     }
     WHEN("Constructing the default triangulation.")

diff --git a/tests/Geometry_test.cpp b/tests/Geometry_test.cpp
@@ -102,11 +102,13 @@ SCENARIO("3-Geometry classification" * doctest::test_suite("geometry"))
                                   triangulation.number_of_vertices()));
 
         // Human verification
-        triangulation.print_cells();
         fmt::print("There are {} edges.\n", geometry.N1);
         fmt::print("There are {} timelike edges and {} spacelike edges.\n",
                    geometry.N1_TL, geometry.N1_SL);
+#ifndef NDEBUG
+        triangulation.print_cells();
         triangulation.print_edges();
+#endif
         fmt::print(
             "There are {} vertices with a max timevalue of {} and a min "
             "timevalue of {}.\n",