Skip to content

Commit

Permalink
fix: AppleClang
Browse files Browse the repository at this point in the history
C++23 support check left out AppleClang
  • Loading branch information
acgetchell committed Nov 1, 2024
1 parent 0add19b commit ccb47e7
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
10 changes: 9 additions & 1 deletion .github/workflows/macos.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
name: macOS

on: [workflow_dispatch]
on:
push:
branches:
- main
- develop
pull_request:
branches:
- develop
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSI
message(FATAL_ERROR "GCC 12.2 or higher required for C++23 support")
elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "16.0")
message(FATAL_ERROR "Clang 16.0 or higher required for C++23 support")

Check failure on line 75 in CMakeLists.txt

View workflow job for this annotation

GitHub Actions / build

Clang 16.0 or higher required for C++23 support

Check failure on line 75 in CMakeLists.txt

View workflow job for this annotation

GitHub Actions / build

Clang 16.0 or higher required for C++23 support
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "14.0")
message(FATAL_ERROR "AppleClang 14.0 or higher required for C++23 support")
endif()

# Set NOMINMAX to avoid min/max macro errors on Windows in date.h
Expand Down

0 comments on commit ccb47e7

Please sign in to comment.