Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch 2 v3 #78

Draft
wants to merge 211 commits into
base: feature/catch2v3
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
211 commits
Select commit Hold shift + click to select a range
63b796e
(feature) Replace Catch2 with doctest
acgetchell May 10, 2022
55fef57
(test) Fix all tests to run on doctest
acgetchell May 18, 2022
5f37c32
(fix) Various issues from ASAN
acgetchell May 19, 2022
2c96ea2
(test) Use C++20 Mathematical constants
acgetchell May 24, 2022
5f70aa7
(test) Fix SonarLint warning
acgetchell May 24, 2022
28e9ef9
Merge branch 'feature/doctest' into develop
acgetchell May 25, 2022
87c5685
(refactor) Start migrating features for bistellar move
acgetchell May 26, 2022
e38be2f
(refactor) Ergodic_moves_3 operate on Manifold_3, helpers on Delaunay_3
acgetchell Jun 7, 2022
53ec486
(refactor) Simplify bistellar_flip_really
acgetchell Jun 9, 2022
1abf22b
(test) Update doctest and remove Catch2 references
acgetchell Jun 21, 2022
4ccedc3
(fix) Fix bug identified by PVS Studio
acgetchell Jun 21, 2022
78da939
(fix) clang-tidy warnings
acgetchell Jun 22, 2022
4189c59
(fix) fmt::format strings, update to latest vcpkg
acgetchell Aug 17, 2022
72580ce
(fix) Don't const-qualify functions that return by value
acgetchell Aug 17, 2022
6166dbb
(fix) More formatting and some logic fixes
acgetchell Aug 17, 2022
d72e416
(fix) Clang-tidy fixes
acgetchell Aug 17, 2022
139fa8b
(fix) clang-format
acgetchell Aug 17, 2022
48a5f95
(ci) Update to Boost 1.80
acgetchell Aug 26, 2022
19ab7d7
(ci) Update vcpkg
acgetchell Sep 17, 2022
43e175c
(ci)
acgetchell Sep 30, 2022
ebab690
(build) Update Slurm script for HPC runs
acgetchell Oct 14, 2022
43b040f
(refactor) Run include-what-you-use
acgetchell Nov 8, 2022
0735296
(fix, ci) Yep, iwyu makes some bad suggestions
acgetchell Nov 8, 2022
94e92ec
(fix) Fix clang-format and iwyu errors
acgetchell Nov 8, 2022
5ccc47d
(ci) Fix CodeCov, update clang on Travis-CI
acgetchell Nov 8, 2022
af57547
(ci) Fix Travis-CI
acgetchell Nov 8, 2022
f3f9b82
(ci) Fix GitHub Actions, clang-format
acgetchell Nov 9, 2022
09fc500
(refactor) Fix clang-tidy warnings
acgetchell Nov 10, 2022
33530c3
(refactor) More clang-tidy fixes
acgetchell Nov 10, 2022
76e12c2
(refactor) Bi-stellar flip
acgetchell Nov 15, 2022
642772f
(ci, fix, bug) Fix Travis-CI, clang-tidy, and a bug
acgetchell Nov 15, 2022
b18b962
(ci) Trying a fix for Travis-CI
acgetchell Nov 15, 2022
14cf635
(ci) Update SonarCloud, GitHub Actions
acgetchell Nov 29, 2022
1ab2038
(doc) Update documentation
acgetchell Dec 2, 2022
130dc1b
(performance) Fix clang-tidy warnings
acgetchell Dec 15, 2022
9f8003b
(refactor) Use c++20 features now supported in all 4 compilers
acgetchell Dec 15, 2022
aed36c6
(feature) Visualization via Qt5
acgetchell Dec 17, 2022
650f2ee
(ci) Fix CI build dependencies
acgetchell Dec 17, 2022
cbfdffa
(ci) Only build cdt-viewer on macOS
acgetchell Dec 18, 2022
cfcba15
(feature) Read file and draw
acgetchell Dec 23, 2022
afd790a
(feature) Reading and writing triangulations from files
acgetchell Dec 23, 2022
b957b3f
(refactor) Make write_file easier to use
acgetchell Dec 26, 2022
7ae12a9
(refactor, test, docs)
acgetchell Dec 27, 2022
f9901d9
(feature) Add functionality to read file from command line
acgetchell Dec 28, 2022
a7f567d
(doc) Update documentation prior to merge [skip ci]
acgetchell Dec 28, 2022
eae5d01
Merge branch 'feature/qt' into develop
acgetchell Dec 28, 2022
bc062dd
(docs) Update documentation
acgetchell Dec 31, 2022
cba43ef
(ci, docs)
acgetchell Dec 31, 2022
674d9a1
(ci, doc, fix) Happy New Year!
acgetchell Jan 3, 2023
caa27e1
(ci) Remove testing from AppVeyor
acgetchell Jan 3, 2023
11726e0
(ci) Fix AppVeyor caching
acgetchell Jan 3, 2023
a4eed8c
(docs, ci) Use new CodeCov uploader
acgetchell Jan 4, 2023
ec614dd
(ci) Fix CodeCov uploader [skip ci]
acgetchell Jan 4, 2023
6da59a1
(ci) Don't run vcpkg manifest mode in dev mode [ci skip]
acgetchell Jan 4, 2023
b1fcf5e
Merge branch 'feature/new-codecov-uploader' into develop
acgetchell Jan 4, 2023
5ab2ed7
(ci) Fiddling with CMakePresets for new CodeCov uploader [ci skip]
acgetchell Jan 4, 2023
ad3ab3c
(ci) Turn off cmake dev errors [skip ci]
acgetchell Jan 4, 2023
7fe8a32
(ci) More CMakePresets fun to fix CodeCov [skip ci]
acgetchell Jan 4, 2023
09b4884
(ci) Fixing weird filesystem errors [ci skip]
acgetchell Jan 4, 2023
a97b220
(ci) Build CodeCov with clang [ci skip]
acgetchell Jan 4, 2023
282c154
(ci) Remove options not supported by clang [ci skip]
acgetchell Jan 4, 2023
3ca72bd
(ci) Fix CodeCov upload
acgetchell Jan 6, 2023
9488c11
(ci) Fix Codecov uploader [skip ci]
acgetchell Jan 6, 2023
7c27dc2
(ci) Fix gcc for Codecov uploader [ci skip]
acgetchell Jan 6, 2023
ab0a695
(ci) Use gcc-12 and clang-15 for GitHub Actions [ci skip]
acgetchell Jan 6, 2023
5bf7f58
(ci) Explicitly set compiler in setup-gcc and setup-clang [ci skip]
acgetchell Jan 6, 2023
ff36f82
(ci) Update to gcc-12 and clang-15
acgetchell Jan 6, 2023
ce27bb5
(ci) Fix Travis
acgetchell Jan 6, 2023
abbf890
(ci) Revert Travis-CI to clang-14 and gcc-11
acgetchell Jan 6, 2023
bfa502c
(ci) Use cmake presets for GitHub Actions
acgetchell Jan 7, 2023
135b7dc
(ci) More GitHub Actions and AppVeyor tuning with CMakePresets.json
acgetchell Jan 7, 2023
6321a8d
(ci) Fix AppVeyor and SonarCloud
acgetchell Jan 7, 2023
0d27d0a
(ci) Fix AppVeyor and SonarCloud, try #2
acgetchell Jan 7, 2023
ac4e03e
(ci) AppVeyor #3
acgetchell Jan 7, 2023
5c0385a
(ci) Try to resolve gcov/gcc version mismatch
acgetchell Jan 11, 2023
a631798
(ci) Turn off QT in GitHub Actions
acgetchell Jan 12, 2023
0338b74
(ci) Also remove the tests for cdt-viewer [ci skip]
acgetchell Jan 12, 2023
6c0885d
(test) Write a bistellar-flip test harness
acgetchell Jan 13, 2023
b4cd264
(ci) Delete build caches
acgetchell Jan 17, 2023
496adc5
(ci) Revert SonarCloud and CodeCov ci script , AppVeyor caching
acgetchell Jan 17, 2023
bd41945
(ci) Fix codecov and hopefully SonarCloud coverage
acgetchell Jan 19, 2023
13932ac
(ci) Coverage should work now ...
acgetchell Jan 19, 2023
558e49e
Update packages, debug draw
acgetchell Feb 9, 2023
6fd3941
Update vcpkg
acgetchell Feb 24, 2023
6e00b8a
(fix) Enforce FoliatedTriangulation class invariant
acgetchell Mar 22, 2023
76355e6
(fix) Fix CI errors
acgetchell Mar 22, 2023
21ea2c5
(fix) More clang-format
acgetchell Mar 22, 2023
a05eea4
Revert to using CodeCov GitHub Action
acgetchell Mar 26, 2023
6da7e32
Add method to read Delaunay triangulation in the Manifold
acgetchell Mar 27, 2023
1c83943
Fix get_triangulation().get_delaunay calls
acgetchell Mar 30, 2023
319bd7e
(fix) Fix make_triangulation and is_62_movable
acgetchell Mar 30, 2023
bbd8555
(ci, fix) Add clang-tidy check, fix README
acgetchell Mar 31, 2023
6e2d8de
(fix) Fixes to CodeCov and clang-tidy
acgetchell Mar 31, 2023
6f306ba
(fix) clang-format, doctests
acgetchell Apr 1, 2023
b0efd23
(fix) README, more tests
acgetchell Apr 1, 2023
a9a08a1
Remove -Wcomment warnings, use CHECK_EQ, REQUIRE_EQ
acgetchell Apr 7, 2023
b0a39bb
(ci) Try new CodeCov GitHub Action
acgetchell Apr 11, 2023
444cc6d
(refactor) Update to Boost 1.82
acgetchell Apr 16, 2023
ccdd09d
(ci) Update AppVeyor and CodeCov
acgetchell May 5, 2023
c458339
(test) Activate certain tests
acgetchell May 5, 2023
fef1c02
(ci) Update CodeCov and SonarCloud to use gcc-12
acgetchell May 5, 2023
30256e6
(ci, refactor) Undo gcc-12 on CodeCov and SonarCloud
acgetchell May 6, 2023
5466d0a
Add back default cases and remove Expects and Ensures
acgetchell May 8, 2023
debe0be
Update vcpkg
acgetchell Jun 1, 2023
303f93a
Update packages
acgetchell Jun 10, 2023
9609bb7
Update vcpkg to commit 5d2a0a9 in workflows and tests
acgetchell Jun 16, 2023
0420b15
Refactor build and test scripts for CI/CD workflows
acgetchell Jun 16, 2023
498dcef
feat: Add test for check_move function
acgetchell Jul 7, 2023
46609b8
Update AppVeyor and Codecov configurations
acgetchell Jul 7, 2023
d861cac
Refactor build and test scripts, update dependencies
acgetchell Jul 7, 2023
d41deea
Refactor code to use `foliated_triangulations::make_causal_vertices` …
acgetchell Jul 7, 2023
e93f8d6
Refactor code for Manifold initialization and mutation
acgetchell Jul 7, 2023
2f7a188
Update GCC and Clang versions in CI configuration
acgetchell Jul 8, 2023
4c43907
Fixed FoliatedTriangulation copy constructor
acgetchell Jul 10, 2023
f6bc5a8
Fix macOS build
acgetchell Jul 10, 2023
b515f3c
Update vcpkgGitCommitId in workflow files
acgetchell Jul 13, 2023
d7a450b
Update vcpkgGitCommitId in workflow files
acgetchell Jul 27, 2023
d216edf
Update vcpkgGitCommitId in GitHub workflows
acgetchell Aug 1, 2023
4896058
Update vcpkgGitCommitId in GitHub workflows
acgetchell Aug 22, 2023
eb2dd7c
Add get_cell function
acgetchell Sep 4, 2023
dd39db6
Add new function
acgetchell Sep 7, 2023
5a09993
Fix AppVeyor
acgetchell Sep 8, 2023
5c6cfe3
Boost 1.83
acgetchell Sep 21, 2023
624b15c
Backed out qt
acgetchell Sep 26, 2023
ba55e74
Use a span of Vertex_handles for read-only
acgetchell Sep 27, 2023
0bdf8db
More ranges
acgetchell Sep 29, 2023
280b2e0
Re-added Qt
acgetchell Oct 4, 2023
04866be
feat: Add <chrono> header for time-related functionality
acgetchell Oct 5, 2023
a9b7134
Refactor code to remove unused code and add debug log messages
acgetchell Oct 6, 2023
bdb5237
Add Linux Clang with pkgx workflow and comment out unsupported std::f…
acgetchell Oct 6, 2023
1e91e2b
Update Linux-clang-pkgx workflow [skip ci]
acgetchell Oct 6, 2023
7f7323d
Start using pkgx on ci
acgetchell Oct 6, 2023
dd1dd05
Switch more GitHub Actions to pkgx
acgetchell Oct 6, 2023
5eb1578
Fix GitHub Actions
acgetchell Oct 6, 2023
09d913d
De-cluttering test printouts
acgetchell Oct 10, 2023
36785a7
Use C++23 standard
acgetchell Oct 23, 2023
170e065
Use c++23 std::expected
acgetchell Oct 24, 2023
a3b4b66
Reset develop back to C++20
acgetchell Oct 24, 2023
e138350
Merge remote-tracking branch 'origin/develop' into develop
acgetchell Oct 24, 2023
c7ce11d
Revert to C++20
acgetchell Oct 24, 2023
28e4629
feat: Add print_cell function and update print_cells
acgetchell Nov 6, 2023
dca7340
feat: Add cache directory to AppVeyor configuration
acgetchell Nov 6, 2023
8443a78
Update clang-format version to 17 and update compiler versions in Tra…
acgetchell Nov 7, 2023
a5bb7cd
Remove unused compilers and dependencies in .travis.yml
acgetchell Nov 7, 2023
5ab9ba3
Update before_install script in .travis.yml
acgetchell Nov 7, 2023
adb079f
Update Travis CI configuration to use `curl -fsS` instead of `eval "$…
acgetchell Nov 7, 2023
c6098d0
Update Travis CI configuration
acgetchell Nov 7, 2023
ed905ab
Refactor GitHub workflow files for improved concurrency handling
acgetchell Nov 7, 2023
8605c78
Travis-CI and pkgx don't get along
acgetchell Nov 7, 2023
f5d30af
Refactor GitHub Actions workflows to use a dynamic concurrency group
acgetchell Nov 7, 2023
e451d33
Update vcpkg, AppVeyor, more ranges
acgetchell Nov 23, 2023
6930537
Apply a bunch of suggested fixes
acgetchell Nov 23, 2023
947ec03
feat: Add Python 3.11 support to macOS workflow
acgetchell Nov 25, 2023
e4b163e
feat: Update macOS workflow and MoveCommand class
acgetchell Nov 25, 2023
9a7cca3
Remove unnecessary files and update dependencies in macOS workflow.
acgetchell Nov 25, 2023
77fcb7c
Update macOS and Travis CI configurations
acgetchell Nov 25, 2023
d47bd93
Use pkgx to install gcc-13 and clang-16 on Travis-CI
acgetchell Nov 25, 2023
5ee5af8
Travis-CI + pkgx
acgetchell Nov 25, 2023
94947c6
Bog standard install of gcc-13
acgetchell Nov 25, 2023
655286e
Add gcc-12 to the list of required packages in .travis.yml
acgetchell Nov 25, 2023
52fd3ae
Update Travis CI configuration
acgetchell Nov 25, 2023
c0c02fd
Update compiler versions in .travis.yml
acgetchell Nov 25, 2023
6cf22dc
Update macOS.yml and .travis.yml
acgetchell Nov 26, 2023
26f2dca
Fix Travis, update GitHub actions
acgetchell Nov 28, 2023
34c1267
Deprecate Doxygen on Travis-CI [skip ci]
acgetchell Nov 28, 2023
86ff224
Still fixing macos on GitHub [skip ci]
acgetchell Nov 28, 2023
ea39270
And another python3 error in GHA [skip ci]
acgetchell Nov 28, 2023
9da2499
Yet another python3 update error in GHA [skip ci]
acgetchell Nov 28, 2023
470ff3f
Setup Valgrind on GHA [skip ci]
acgetchell Nov 28, 2023
572fca2
Add Valgrind installation to the workflow
acgetchell Nov 28, 2023
294393f
Fix macOS and Valgrind [ci skip]
acgetchell Nov 28, 2023
9cbc948
Fix Valgrind [ci skip]
acgetchell Nov 28, 2023
3606b8a
Fix known Valgrind/ASAN issue [skip ci]
acgetchell Nov 28, 2023
821f499
Update Valgrind configuration for Clang [ci skip]
acgetchell Nov 28, 2023
5167aa2
Fix Valgrind on clang [ci skip]
acgetchell Nov 29, 2023
f6dde57
Revert Valgrind back to g++, at least some tests work [skip ci]
acgetchell Nov 29, 2023
2df42ce
Run Valgrind checks separately [ci skip]
acgetchell Nov 29, 2023
effab71
Update vcpkg
acgetchell Nov 30, 2023
eb1ee2d
Enable ASAN on GHA [skip ci]
acgetchell Nov 30, 2023
aa4fad9
Migrate Sanitizers to GHA [skip ci]
acgetchell Nov 30, 2023
8ef7e8b
Use a repo variable to update vcpkg
acgetchell Nov 30, 2023
de41ab3
Add Cppcheck workflow, presets, and build steps [skip ci]
acgetchell Nov 30, 2023
576b135
Update HPC and PVS Studio scripts
acgetchell Dec 13, 2023
17f8302
Update Slurm script
acgetchell Dec 20, 2023
25379e6
Boost 1.84
acgetchell Jan 27, 2024
5812db7
Update vcpkg to fix macOS qt build issue
acgetchell Feb 5, 2024
367c374
Fixing vcpkg build of python on macOS [skip ci]
acgetchell Feb 5, 2024
e3b083d
Remaining vcpkg python macOS update fixes [skip ci]
acgetchell Feb 5, 2024
891c1fb
Still need old fixes too [skip ci]
acgetchell Feb 6, 2024
ca6b24c
Fix docopt
acgetchell Mar 11, 2024
83cd610
Fix docopt #2
acgetchell Mar 11, 2024
fc1ac31
ci: Try clang-18 via pkgx [ci skip]
acgetchell Apr 12, 2024
0dba855
ci: Fix when checks run
acgetchell Apr 13, 2024
c9733e4
ci: Update to clang-18
acgetchell Apr 13, 2024
805d5ed
ci, style: clang-format and macOS
acgetchell Apr 13, 2024
e00cc47
test: format/fix tests
acgetchell Apr 14, 2024
9217f34
feat: Switch from docopt to boost::program_options
acgetchell Apr 15, 2024
f3eb66b
ci, fix: macOS and Linux builds
acgetchell Apr 15, 2024
d423ad4
feat: Replace docopt on cdt
acgetchell Apr 16, 2024
a339af5
feat: Replace docopt on cdt-viewer
acgetchell Apr 16, 2024
634398d
docs: Update documentation [ci skip]
acgetchell Apr 16, 2024
754094f
ci, fix: Fix fmt::join, update Github actions
acgetchell Aug 24, 2024
6e6e5dd
ci: update GitHub Actions
acgetchell Aug 24, 2024
2dc8945
ci: Update remaining actions
acgetchell Aug 24, 2024
63785d6
fix: MSVC error
acgetchell Aug 24, 2024
771f01d
ci: Check if clang-19 available [skip ci]
acgetchell Sep 23, 2024
cc17bc1
ci: Update to clang-19
acgetchell Sep 23, 2024
a79eed9
Feature/c++23 (#76)
acgetchell Sep 24, 2024
6d8a435
Feature/fix appveyor (#77)
acgetchell Nov 5, 2024
390fe0e
ci: Fix macOS GitHub Action [skip ci]
acgetchell Nov 5, 2024
0f64010
ci: Coderabbit and macOS update
acgetchell Nov 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
(fix) Fix clang-format and iwyu errors
GHA should all pass now
acgetchell committed Nov 8, 2022
commit 94e92ecd40792f24c78f2fe097b2762d4fd73ff4
2 changes: 1 addition & 1 deletion .github/workflows/macos.yml
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ on: [push, pull_request, workflow_dispatch]

jobs:
build:
runs-on: macos-latest
runs-on: macos-12

steps:
- uses: actions/checkout@v2
21 changes: 11 additions & 10 deletions include/Foliated_triangulation.hpp
Original file line number Diff line number Diff line change
@@ -986,7 +986,8 @@ namespace foliated_triangulations
{}

/// @brief Copy/Move Assignment operator
auto operator=(FoliatedTriangulation other) noexcept->FoliatedTriangulation&
auto operator=(FoliatedTriangulation other) noexcept
-> FoliatedTriangulation&
{
swap(other, *this);
return *this;
@@ -1216,8 +1217,8 @@ namespace foliated_triangulations
} // N1_SL

/// @return Container of timelike edges
[[nodiscard]] auto get_timelike_edges()
const noexcept->Edge_container const&
[[nodiscard]] auto get_timelike_edges() const noexcept
-> Edge_container const&
{
return m_timelike_edges;
} // get_timelike_edges
@@ -1229,7 +1230,7 @@ namespace foliated_triangulations
} // get_spacelike_edges

/// @return Container of vertices
[[nodiscard]] auto get_vertices() const noexcept->Vertex_container const&
[[nodiscard]] auto get_vertices() const noexcept -> Vertex_container const&
{
return m_points;
} // get_vertices
@@ -1265,8 +1266,8 @@ namespace foliated_triangulations
/// @see
/// https://doc.cgal.org/latest/TDS_3/classTriangulationDataStructure__3.html#a93f8ab30228b2a515a5c9cdacd9d4d36
template <typename VertexHandle>
[[nodiscard]] auto incident_cells(VertexHandle && t_vh)
const noexcept->decltype(auto)
[[nodiscard]] auto incident_cells(VertexHandle && t_vh) const noexcept
-> decltype(auto)
{
Cell_container inc_cells;
get_delaunay().tds().incident_cells(std::forward<VertexHandle>(t_vh),
@@ -1282,8 +1283,8 @@ namespace foliated_triangulations
/// @see
/// https://doc.cgal.org/latest/TDS_3/classTriangulationDataStructure__3.html#a93f8ab30228b2a515a5c9cdacd9d4d36
template <typename... Ts>
[[nodiscard]] auto incident_cells(Ts && ... args)
const noexcept->decltype(auto)
[[nodiscard]] auto incident_cells(Ts && ... args) const noexcept
-> decltype(auto)
{
return get_delaunay().tds().incident_cells(std::forward<Ts>(args)...);
} // incident_cells
@@ -1397,13 +1398,13 @@ namespace foliated_triangulations
} // get_three_one

/// @return Container of (2,2) cells
[[nodiscard]] auto get_two_two() const noexcept->Cell_container const&
[[nodiscard]] auto get_two_two() const noexcept -> Cell_container const&
{
return m_two_two;
} // get_two_two

/// @return Container of (1,3) cells
[[nodiscard]] auto get_one_three() const noexcept->Cell_container const&
[[nodiscard]] auto get_one_three() const noexcept -> Cell_container const&
{
return m_one_three;
} // get_one_three
13 changes: 7 additions & 6 deletions include/Manifold.hpp
Original file line number Diff line number Diff line change
@@ -126,7 +126,8 @@ namespace manifolds
} // update

/// @return A read-only reference to the triangulation
[[nodiscard]] auto get_triangulation() const noexcept->Triangulation const&
[[nodiscard]] auto get_triangulation() const noexcept
-> Triangulation const&
{
return std::cref(m_triangulation);
} // get_triangulation
@@ -185,7 +186,7 @@ namespace manifolds
/// @param t_edge_candidate The edge to test
/// @return True if the candidate is an edge
[[nodiscard]] auto is_edge(Edge_handle_t<3> const& t_edge_candidate)
const noexcept->bool
const noexcept -> bool
{
return m_triangulation.get_delaunay().tds().is_edge(
t_edge_candidate.first, t_edge_candidate.second,
@@ -293,14 +294,14 @@ namespace manifolds

/// @brief Perfect forwarding to FoliatedTriangulation_3.incident_cells()
template <typename... Ts>
[[nodiscard]] auto incident_cells(Ts && ... args)
const noexcept->decltype(auto)
[[nodiscard]] auto incident_cells(Ts && ... args) const noexcept
-> decltype(auto)
{
return m_triangulation.incident_cells(std::forward<Ts>(args)...);
} // incident_cells

/// @brief Call to triangulation_.get_timelike_edges()
[[nodiscard]] auto get_timelike_edges() const noexcept->auto const&
[[nodiscard]] auto get_timelike_edges() const noexcept -> auto const&
{
return m_triangulation.get_timelike_edges();
} // get_timelike_edges
@@ -312,7 +313,7 @@ namespace manifolds
} // get_spacelike_edges

/// @brief Call FoliatedTriangulation_3.get_vertices()
[[nodiscard]] auto get_vertices() const noexcept->auto const&
[[nodiscard]] auto get_vertices() const noexcept -> auto const&
{
return m_triangulation.get_vertices();
} // get_vertices
2 changes: 1 addition & 1 deletion include/Periodic_3_triangulations.hpp
Original file line number Diff line number Diff line change
@@ -54,7 +54,7 @@ void make_random_T3_triangulation(T* T3, int simplices, int timeslices) noexcept
int points_per_timeslice = simplices_per_timeslice / 6;
/// We're working on 2 dimensional random points with the z component
/// fixed by the timeslice
const int dim = 2;
int const dim = 2;

std::vector<Point> v;
v.reserve(points);
2 changes: 1 addition & 1 deletion include/Triangulation_traits.hpp
Original file line number Diff line number Diff line change
@@ -55,7 +55,7 @@ struct TriangulationTraits<3>

using Spherical_points_generator = CGAL::Random_points_on_sphere_3<Point>;

static constexpr int origin = 0;
static int constexpr origin = 0;
};

#endif // CDT_PLUSPLUS_TRIANGULATION_TRAITS_HPP
3 changes: 1 addition & 2 deletions src/bistellar.cpp
Original file line number Diff line number Diff line change
@@ -13,13 +13,12 @@

#include <algorithm>
#include <cstdlib>
#include <gsl/gsl_assert>
#include <gsl/assert>
#include <iterator>
#include <numbers>
#include <vector>

#include "Ergodic_moves_3.hpp"
#include "Foliated_triangulation.hpp"

using Cell_handle = Delaunay::Cell_handle;
using Edge_handle = CGAL::Triple<Cell_handle, int, int>;
6 changes: 3 additions & 3 deletions src/cdt-opt.cpp
Original file line number Diff line number Diff line change
@@ -27,10 +27,10 @@ try
constexpr Int_precision simplices = 64;
constexpr Int_precision timeslices = 3;
/// @brief Constants in units of \f$c=G=\hbar=1 \alpha\approx 0.0397887\f$
constexpr auto alpha = static_cast<long double>(0.6);
constexpr auto k = static_cast<long double>(1.1); // NOLINT
auto constexpr alpha = static_cast<long double>(0.6);
auto constexpr k = static_cast<long double>(1.1); // NOLINT
/// @brief \f$\Lambda=2.036\times 10^{-35} s^{-2}\approx 0\f$
constexpr auto lambda = static_cast<long double>(0.1);
auto constexpr lambda = static_cast<long double>(0.1);
constexpr Int_precision passes = 10;
constexpr Int_precision checkpoint = 10;

6 changes: 4 additions & 2 deletions tests/Ergodic_moves_3_test.cpp
Original file line number Diff line number Diff line change
@@ -18,8 +18,10 @@
using namespace std;
using namespace manifolds;

static inline auto constexpr RADIUS_2 = 2.0 * std::numbers::inv_sqrt3_v<double>;
static inline auto constexpr SQRT_2 = std::numbers::sqrt2_v<double>;
static inline std::floating_point auto constexpr RADIUS_2 =
2.0 * std::numbers::inv_sqrt3_v<double>;
static inline std::floating_point auto constexpr SQRT_2 =
std::numbers::sqrt2_v<double>;
static inline auto constexpr INV_SQRT_2 = 1 / SQRT_2;

SCENARIO(