Base Bot #55
Merged
Base Bot #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporated drop rates to add multiple ores when the avatar mines
# Conflicts: # game/controllers/master_controller.py # game/controllers/mine_controller.py # game/quarry_rush/tech/tech.py
…ow for new ores to be generated. fixed infinite loop in inventory_manager.py
KingPhilip14
requested changes
Dec 29, 2023
base_client.py
Outdated
|
|
||
| # This is where your AI will decide what to do | ||
| def take_turn(self, turn, actions, world, avatar): | ||
| def take_turn(self, turn: int, actions: ActionType, world, avatar): |
There was a problem hiding this comment.
Why was the type hinting removed here?
base_client.py
Outdated
| """ | ||
| return self.find_all(world, lambda tile: tile.occupied_by is not None and tile.occupied_by.object_type == object_type) | ||
|
|
||
| def find_all(self, world, criteria): |
There was a problem hiding this comment.
We already have something like this in game_board.py called get_objects where it takes the object type and gives back a list of tuples of the object and its coordinates. This is good but ends up being redundant.
game/config.py
Outdated
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| MAX_SECONDS_PER_TURN = 0.1 # max number of basic operations clients have for their turns | |||
|
|
|||
| MAX_NUMBER_OF_ACTIONS_PER_TURN = 2 # max number of actions per turn is currently set to 2 | |||
| MAX_NUMBER_OF_ACTIONS_PER_TURN = 1000 # master_controller will be handling max actions enforcement for Byte-le 2024 "Quarry Rush" | |||
There was a problem hiding this comment.
There will only be 5 max actions per turn because of a max of 4 movement options in a turn and the auto-selling action. As you already established in the master controller, any other action will take the entire turn. Change this here to reflect this and not loop an unnecessary amount
KingPhilip14
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.