Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power-MIAB create #5330

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Conversation

lifeboy
Copy link
Contributor

@lifeboy lifeboy commented Oct 14, 2024

Power-Mail-in-a-Box has an upgraded API interface which requires a slightly modified call mechanism to create TXT records. This was previously added to dns_miab.sh, but the conflict has necessitated this separate api_pmiab.sh.

Power-Mail-in-a-Box has an updated API which requires a different format.
Correct comments
Correct typo
Correcte site detail for PMIAB
Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@lifeboy
Copy link
Contributor Author

lifeboy commented Oct 14, 2024

First attempt pull-request was wrong, hence this new one.

@lifeboy
Copy link
Contributor Author

lifeboy commented Oct 22, 2024

Bump

@Neilpang
Copy link
Member

Neilpang commented Nov 3, 2024

@lifeboy
Copy link
Contributor Author

lifeboy commented Nov 3, 2024

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Below it shows all checks have passed? Sorry if I'm ignorant of the process, but what did I miss, @Neilpang ?

@Neilpang
Copy link
Member

Neilpang commented Nov 3, 2024

@lifeboy
Copy link
Contributor Author

lifeboy commented Nov 4, 2024

All checks are now completed successfully.

@lifeboy
Copy link
Contributor Author

lifeboy commented Nov 13, 2024

@Neilpang, is there something I still have to do before this can be merged?

@Neilpang
Copy link
Member

@lifeboy
Copy link
Contributor Author

lifeboy commented Nov 17, 2024

https://github.com/lifeboy/acme.sh/actions/runs/11813151134

I need some actual pointers on how to address this issue. The log that github generates doesn't show the detail of why a script fails. It's doesn't show the values it uses for the tests, it only shows '******' and I have searched for a long time how to work out what goes wrong. I rerun the same thing a couple of times, recreate the secrets and then suddenly it runs fine. No reasons giving and I'm none the wiser. Surely this is not the way to do software testing?? Shooting shots into the dark without knowing what's going on??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants