Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns_world4you: Adapt to change in world4you.com DeleteDnsRecordForm #6114

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

NerLOR
Copy link
Contributor

@NerLOR NerLOR commented Nov 26, 2024

dns_world4you: Adapt to change in world4you.com DeleteDnsRecordForm

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@NerLOR
Copy link
Contributor Author

NerLOR commented Nov 26, 2024

Welcome First thing: don't send PR to the master branch, please send to the dev branch instead. Please make sure you've read our DNS API Dev Guide and DNS-API-Test. Then reply on this message, otherwise, your code will not be reviewed or merged. We look forward to reviewing your Pull request shortly ✨ 注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

I already read the guides. All tests have passed.

@Neilpang
Copy link
Member

@NerLOR
Copy link
Contributor Author

NerLOR commented Dec 1, 2024

Now really all tests pass! (Sorry for the inconvenience, it seems I missed the failing tests last time...)

@Neilpang Neilpang merged commit b4c02ec into acmesh-official:dev Dec 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants