This repository has been archived by the owner on May 20, 2021. It is now read-only.
Zf reveal destroy #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2016 17:56
Adjust the slider test to be async, otherwise foundation will throw errors because there are async event handlers triggered in their code.
|
@acoustep Anything I need to do to move on this PR? |
|
Sorry, I've only just seen this. Thank you for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
willDestroyElementtypo. It was preventing theshutdownmethod from being triggered.Add zf-reveal test.
Fixed zf-slider test failure caused by
willDestroyElementfix. The slider would ge removed from DOM at the end of the test and foundation's code triggers event handlers async in the Slider plugin, which is expecting the slider element and Slider instance to continue existing.Fixes #26