Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Avoid contacting twice (Fixes #28) #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thomaspaulb
Copy link
Contributor

@thomaspaulb thomaspaulb commented Jul 18, 2023

@thomaspaulb thomaspaulb force-pushed the fix-annotated-tags branch 2 times, most recently from 8e509d5 to f4aaa32 Compare July 18, 2023 14:34
@thomaspaulb thomaspaulb changed the title [DRAFT] Support annotated tags as merge source [ADD] Support annotated tags as merge source Jul 18, 2023
vaab and others added 2 commits July 22, 2023 16:48
…csone#28)

Avoids also contacting twice (``fetch`` and then ``pull``) remote before
merging.

Signed-off-by: Valentin Lab <[email protected]>
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #74 (9016ee7) into master (fe1e0bb) will decrease coverage by 1.03%.
The diff coverage is 83.95%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   82.64%   81.61%   -1.03%     
==========================================
  Files           6        6              
  Lines         409      457      +48     
==========================================
+ Hits          338      373      +35     
- Misses         71       84      +13     
Impacted Files Coverage Δ
git_aggregator/repo.py 73.92% <83.95%> (-0.21%) ⬇️

@thomaspaulb thomaspaulb changed the title [ADD] Support annotated tags as merge source [RFR] Avoid contacting twice (Fixes #28) Jul 22, 2023
@thomaspaulb
Copy link
Contributor Author

Seems like the only cause for keeping this open is #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants