Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vehicle counts layer to show all years and emphasize data source #485

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Update vehicle counts layer to show all years and emphasize data source #485

merged 1 commit into from
Mar 14, 2024

Conversation

dabreegster
Copy link
Contributor

Just the first task from #482. Before pushing, we need to update the pmtiles file

@dabreegster dabreegster requested a review from Pete-Y-CS March 13, 2024 11:01
Pete-Y-CS
Pete-Y-CS approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Pete-Y-CS Pete-Y-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, can't see it working because I think it's not gone up to s3 bucket? I'll try locally and if we can sort it out today I'm happy to merge and upload to bucket

@dabreegster
Copy link
Contributor Author

S3 updated now, you can generate yourself or copy https://atip.uk/layers/v1/vehicle_counts.pmtiles to GCS. Please update manifests when done, and I'll merge then, so there's minimal outage time

@dabreegster dabreegster merged commit 7afd039 into main Mar 14, 2024
2 checks passed
@dabreegster dabreegster deleted the vehicle_counts branch March 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pete-Y-CS Pete-Y-CS Pete-Y-CS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dabreegster @Pete-Y-CS