Rewrite the route snapper #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the option to avoid doubling back. It doesn't have much effect on spurs in general and has only confused users Rethink the route snapper state management from scratch -- move it to the Svelte side. Use markers for managing waypoints. Basic idea started, but no intermediate waypoints yet Introduce explicit modes. Show intermediate waypoints as more markers. Inserting them doesn't quite work yet, but started. Switch to new stateless WASM API. Intermediate nodes are now properly insertable, but not yet draggable Show preview when appending/prepending Merge with draw toolbar changes (leaving some problems)
after releasing the drag.
dabreegster
force-pushed
the
route_snapper_next_gen
branch
from
c82a5cb to
1ef7cc3
Compare
… out some of the old stuff.
Pete-Y-CS
approved these changes
Nov 25, 2024
| controls = "route"; | ||
| } else if (feature.geometry.type == "Polygon") { | ||
| if (feature.properties.waypoints) { | ||
| $routeTool?.editExistingArea(feature as Feature<Polygon, AreaProps>); | ||
| $routeTool?.addEventListenerSuccess(onSuccess); |
There was a problem hiding this comment.
Do we want to now delete these functions? looks like they're no longer used to me
There was a problem hiding this comment.
addEventListenerSuccess and such? They're in the upstream package https://github.com/dabreegster/route_snapper/blob/main/route-snapper-ts/src/index.ts. We essentially stop using route-snapper-ts in this PR, using part of the WASM API directly. I'm still depending on route-snapper-ts here for now to get RouteProps and a few convenient definitions, but could maybe clean that up later too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a total refresh of the idea of the route and area snapper:
I think this PR represents the MVP. #9 has some smaller followups that aren't critical.
Demo: Run locally or https://acteng.github.io/atip/route_snapper_next_gen/files.html?authority=TA_West%20Yorkshire%20Combined%20Authority&schema=v2