Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detray to v82 #776

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Update detray to v82 #776

merged 2 commits into from
Nov 21, 2024

Conversation

beomki-yeo
Copy link
Contributor

Update detray to v82

@stephenswat
Copy link
Member

Looks good; last time I tried to update the Detray version the CI exploded but let's see what happens. 🤞

@beomki-yeo
Copy link
Contributor Author

I had to put the variable into the ckf_aborter (path_from_surface) which was cleaned up by acts-project/detray#879

@beomki-yeo
Copy link
Contributor Author

beomki-yeo commented Nov 21, 2024 •
edited
Loading

Review? @stephenswat @niermann999 @krasznaa

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stephenswat stephenswat merged commit dd918ac into acts-project:main Nov 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niermann999 niermann999 niermann999 approved these changes

@krasznaa krasznaa Awaiting requested review from krasznaa

@stephenswat stephenswat Awaiting requested review from stephenswat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beomki-yeo @stephenswat @niermann999