Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a memory limited hashset with LocalVocab #1570

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Refactor tests.

a73c84a
Select commit
Loading
Failed to load commit list.
Open

Use a memory limited hashset with LocalVocab #1570

Refactor tests.
a73c84a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 12, 2024 in 0s

89.20% (-0.01%) compared to 1bcfeeb

View this Pull Request on Codecov

89.20% (-0.01%) compared to 1bcfeeb

Details

Codecov Report

Attention: Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (1bcfeeb) to head (a73c84a).

Files with missing lines Patch % Lines
src/util/HashSet.h 90.76% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
- Coverage   89.21%   89.20%   -0.01%     
==========================================
  Files         372      373       +1     
  Lines       34723    34789      +66     
  Branches     3915     3919       +4     
==========================================
+ Hits        30979    31035      +56     
- Misses       2471     2480       +9     
- Partials     1273     1274       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.