Support joins between full index scans #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not as inefficient as they used to be and as one might initially suspect. Signed-off-by: Johannes Kalmbach <[email protected]>
Conformance check passed ✅No test result changes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
+ Coverage 89.37% 89.39% +0.01%
==========================================
Files 375 375
Lines 36107 36098 -9
Branches 4077 4074 -3
==========================================
- Hits 32272 32270 -2
+ Misses 2518 2514 -4
+ Partials 1317 1314 -3 ☔ View full report in Codecov by Sentry. |
hannahbast
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, joins between full index scans were explicitly disallowed because their results are bound to be huge. Now that most operations are lazy, they make more send, for example, when counting or grouping the result. They are hence allowed now. In that context, allow
FILTERto be applied as soon as possible also when a full index scan is involved.