Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharks - Ivana #104

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "pwa-node",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for debugging JS in VSCode?

"request": "launch",
"name": "Launch Program",
"skipFiles": [
"<node_internals>/**"
],
"program": "${workspaceFolder}/src/adagrams.js"
}
]
}
123 changes: 119 additions & 4 deletions src/adagrams.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,130 @@
const letterPool = {
A : 9,
B : 2,
C : 2,
D : 4,
E : 12,
F : 2,
G : 3,
H : 2,
I : 9,
J : 1,
K : 1,
L : 4,
M : 2,
N : 6,
O : 8,
P : 2,
Q : 1,
R : 6,
S : 4,
T : 6,
U : 4,
V : 2,
W : 2,
X : 1,
Y : 2,
Z : 1,
};

const letterScores = {
A : 1,
B : 3,
C : 3,
D : 2,
E : 1,
F : 4,
G : 2,
H : 4,
I : 1,
J : 8,
K : 5,
L : 1,
M : 3,
N : 1,
O : 1,
P : 3,
Q : 10,
R : 1,
S : 1,
T : 1,
U : 1,
V : 4,
W : 4,
X : 8,
Y : 4,
Z : 10,
};


export const drawLetters = () => {
// Implement this method for wave 1
const arrayOfLetters = [];

for (let [letter, quantity] of Object.entries(letterPool)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't reassign letter or quantity could we use const instead in the for loop?

for (let i=0; i<quantity; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per js style, we should add spaces around operators

for (let i = 0; i < quantity; i++) {

Here's Google's JS styleguide: https://google.github.io/styleguide/jsguide.html

arrayOfLetters.push(letter);
}
}

const currentHand = [];

for (let i=0; i<10; i++) {
const currentLetter = arrayOfLetters[Math.floor(Math.random() * arrayOfLetters.length)];
currentHand.push(currentLetter);
arrayOfLetters.splice(arrayOfLetters.indexOf(currentLetter), 1);
}

Comment on lines +71 to +76

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

return currentHand;
};

console.log(drawLetters)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove debugging print statements


export const usesAvailableLetters = (input, lettersInHand) => {
// Implement this method for wave 2

const upperCaseWord = input.toUpperCase();

for (let letter of upperCaseWord) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use const instead of let here since we don't need to change the value of letter

if (lettersInHand.includes(letter)) {
lettersInHand.splice(lettersInHand.indexOf(letter), 1);
} else {
return false;
}
}
return true;
};

export const scoreWord = (word) => {
// Implement this method for wave 3
let totalScore = 0;

if (word.length >= 7) {
totalScore += 8
}
Comment on lines +97 to +101

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also see this written with a ternary like:

let totalScore = word.length >= 7 ? 8 : 0;

which would replace what's on line 97


for (let letter of word.toUpperCase()){
totalScore += letterScores[letter]
}
Comment on lines +103 to +105

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you handle input that has characters that are not in letterScores, for example what if word was "cat!" ?

When your for loop gets to "!" then letterScores['!'] will return undefined. When we add undefined to a number like totalScore then the result will be NaN, which introduces a bug.

You could have a conditional check before adding score to total, by checking that the letter is a key in letterScore.

return totalScore;
};

export const highestScoreFrom = (words) => {
// Implement this method for wave 1
let highestScore = 0;
let winningWord = '';

for (let word of words) {
const scoreOfWord = scoreWord(word);

if (scoreOfWord > highestScore){
highestScore = scoreOfWord;
winningWord = word;
} else if (scoreOfWord === highestScore) {
if (winningWord.length === 10){
continue;
} else if (word.length === 10) {
winningWord = word;
} else if (word.length < winningWord.length){
winningWord = word;
}
}
}
return ({"word": winningWord, "score": highestScore});
};
8 changes: 5 additions & 3 deletions test/adagrams.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ describe("Adagrams", () => {
});

it("returns a score of 0 if given an empty input", () => {
throw "Complete test";
expectScores({
'': 0,
});
});

it("adds an extra 8 points if word is 7 or more characters long", () => {
Expand All @@ -133,7 +135,7 @@ describe("Adagrams", () => {
});
});

describe.skip("highestScoreFrom", () => {
describe("highestScoreFrom", () => {
it("returns a hash that contains the word and score of best word in an array", () => {
const words = ["X", "XX", "XXX", "XXXX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };
Expand All @@ -145,7 +147,7 @@ describe("Adagrams", () => {
const words = ["XXX", "XXXX", "X", "XX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };

throw "Complete test by adding an assertion";
expect(highestScoreFrom(words)).toEqual(correct);
});

describe("in case of tied score", () => {
Expand Down