Sea Turtles Carranza, Katina #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jun 21, 2022
src/adagrams.js
Outdated
| }; | ||
| const lettersInHandCopy = [...lettersInHand]; | ||
| const word = input.toUpperCase | ||
| for (let letter of word){ |
There was a problem hiding this comment.
let could be a const here since we aren't alternating input
src/adagrams.js
Outdated
| }; | ||
| const lettersInHandCopy = [...lettersInHand]; | ||
| const word = input.toUpperCase | ||
| for (let letter of word){ |
There was a problem hiding this comment.
your test are failing here because you are using word but the parameter on line 54 is input
src/adagrams.js
Outdated
| for (letter in word.toUpperCase()) | ||
| score += availableLetters[letter][1]; | ||
|
|
||
| if (word.length >= 7) |
There was a problem hiding this comment.
Suggested change
| if (word.length >= 7) | |
| if (word.length >= 7 && word.length <= 10) { |
src/adagrams.js
Outdated
|
|
||
| export const scoreWord = (word) => { | ||
| // Implement this method for wave 3 | ||
| score = 0 |
| 'Y': [2,4], | ||
| 'Z': [1,10] | ||
| } | ||
|
|
||
| export const drawLetters = () => { |
There was a problem hiding this comment.
I would use the spread operator to make a copy of the letterPool
use a for loop to draw 10 letters
use math.floor to make the random draw
push the letter to letterHand
return letterHand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.