C17 Otters - Ada Barries #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let inputSet = new Set(upperCaseInput); | ||
| let handSet = new Set(lettersInHand); | ||
|
|
||
| const extraLetters = (inputSet - handSet); |
| return false; | ||
| } | ||
|
|
||
| for (let i in upperCaseInput) { |
There was a problem hiding this comment.
Your set comparison already took care of finding out if the letters in the input word exist in the hand so this loop isn't necessary.
| if (word.length >= 7) { | ||
| wordScore += 8; | ||
| } | ||
| for (let i in upperCaseWord) { |
There was a problem hiding this comment.
You could use a for ... of loop here to iterate directly over the string characters rather than the index
| // within the above forEach loop if (currentScore > maxScore) { | ||
| // maxScore = currentScore; | ||
| // } | ||
| // loop again through words. (forEach again? there's deffo a better way to do this) |
There was a problem hiding this comment.
Your pseudocode made me chuckle lol. You're on the right track though! It is possible to find the highest scoring word with only one loop. Rather than building a list of words that have the highest score, think about how you can keep track of the current highest scoring word as you iterate over the list of words and how you could compare each word to the current best word.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submitting what i have