-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tori Shade | Otters #83
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful job, Tori! 🎉
This portfolio is playful and full of sensible semantic HTML! I hope you had fun making it because it was a joy for me to plunk around. This project is a Green. 🟢 Please make more websites! 🙏🏻
@@ -1,12 +1,90 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is hands down my favorite page!! These memes!! 💯 💀 🔥
Great job making the wall of memes in the background here!!
</head> | ||
<body> | ||
<header> | ||
<h2 class="title">Tori's Very Sad Portfolio</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sad! Not sad at all!
</div> | ||
</header> | ||
<section class="portfolio-container"> | ||
<p>Follow your curiosity regarding my prior projects. Or don't. You're not missing anything.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL
</head> | ||
<body> | ||
<header> | ||
<h2 class="title">Home</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit: We start with a <h2>
tag and not an <h1>
. It might be misleading if I was using a screen reader (I might wonder where I might have missed the first header!) so I would always start from the top and go down chronologically with semantic header tags!
</header> | ||
<main> | ||
<section class="spotify"> | ||
<iframe src="https://open.spotify.com/embed/playlist/4xzBjcXcutDB4IMiff3vvO?utm_source=generator&theme=0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job implementing an <iframe>
here! This playlist is also * chefkiss * 💯
img [alt="Accounting Memes"] { | ||
opacity: 0.5; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great CSS selector and property combo!
display: flex; | ||
justify-content: space-around; | ||
align-items: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll see this kind of flex / justify content / align items combination of CSS a lot for nav bars too! Great job using a consistent pattern!
position: sticky; | ||
align-items: center; | ||
padding: 10px; | ||
background-color: goldenrod; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOLDENROD 🥇
<nav> | ||
<a href="index.html">Home</a> | ||
<a href="about.html">About </a> | ||
<a href="/assets/Victoria_K_Shade_Resume.pdf">Resume</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job linking a pdf in this anchor tag!
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions
Why is it important to consider and use semantic HTML? | So your website is accessible to everyone.
How did you decide to structure your CSS? Similar to Chris: In alphabetical order by 1) element, 2) class, and 3) id. Looking at my project, I seemed to utilize class selectors the most.
What was the most challenging piece of this assignment? | FORMATTING!
Describe one area that you gained more clarity on when completing this assignment | How HTTP and CSS work together. How HTTP is organized.
Optional |
Did you deploy to GitHub Pages? If so, what is the URL to your website? |