-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otters - Diana M. #90
base: master
Are you sure you want to change the base?
Conversation
Personal Portfolio SiteCongratulations! You're submitting your assignment! Comprehension Questions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this project Diana! Good use of semantic HTML and grid and flex layouts. I am a big fan of your design, very clean and modern looking. Nice touch with the greyscale photo links. This project is green.
</section> | ||
<section class="about-grid-side"> | ||
<div class="line"></div> | ||
<h4>Welcome</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In semantic HTML, header tags should be used to indicate different sections of content, not as stylistic elements. Link
<hr> | ||
<div class="collage-flex"> | ||
<h2>Projects</h2> | ||
<div class="collage-grid"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution with nesting a grid inside a flex!
} | ||
|
||
img.grayscale { | ||
filter: grayscale(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
That's a great question! With display elements like this, none of the semantic tags seem to fit perfectly. The |
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions