Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otters - Diana M. #90

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Otters - Diana M. #90

wants to merge 20 commits into from

Conversation

mm-diana
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?
Why is it important to consider and use semantic HTML?
How did you decide to structure your CSS?
What was the most challenging piece of this assignment?
Describe one area that you gained more clarity on when completing this assignment
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

@mm-diana
Copy link
Author

Comprehension Questions.pdf

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I needed to add alternative texts to images. I still have a warning about sections but I did not change it to a div tag because I thought that div tags aren't semantic html. Should these be updated to a better tag?
Why is it important to consider and use semantic HTML?
It is important for accessibility. It allows screen readers to better understand the layout of the website.
How did you decide to structure your CSS?
I structured my css by placing element selectors first then class selectors and finally ids.
What was the most challenging piece of this assignment?
Describe one area that you gained more clarity on when completing this assignment
It was difficult to use flex and grid. I had to really think about and sometimes draw out what I wanted to see before writing it out in my css file.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? https://arantxax28.github.io/personal-portfolio-site/

Copy link

@jbieniosek jbieniosek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this project Diana! Good use of semantic HTML and grid and flex layouts. I am a big fan of your design, very clean and modern looking. Nice touch with the greyscale photo links. This project is green.

</section>
<section class="about-grid-side">
<div class="line"></div>
<h4>Welcome</h4>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In semantic HTML, header tags should be used to indicate different sections of content, not as stylistic elements. Link

<hr>
<div class="collage-flex">
<h2>Projects</h2>
<div class="collage-grid">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution with nesting a grid inside a flex!

}

img.grayscale {
filter: grayscale();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@jbieniosek
Copy link

jbieniosek commented May 25, 2022

I still have a warning about sections but I did not change it to a div tag because I thought that div tags aren't semantic html. Should these be updated to a better tag?

That's a great question! With display elements like this, none of the semantic tags seem to fit perfectly. The <aside> or <figure> might work better, I don't think either of them will throw an error in the validator if they don't have header tags nested inside of them the way section tags do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants