-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sea Turtles Carranza, Katina #93
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start and you are organized and ready to add more stuff! I linked some articles that can help with making sure your html is semantic and organized. Let me know if you have any questions.
|
||
<h1>All About Katina</h1> | ||
<p>This is information about likes and dislikes for Katina</p> | ||
<footer> This is Katina's footer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the links to your other pages should go inside of a nav tag something like
<header>
<nav>
<ul>
<li><a href="index.html">Home</a></li>
<li><a href="portfolio.html">Portfolio</a></li>
</ul>
</nav>
</header>
<h1> | ||
My Personal Portfolio | ||
</h1> | ||
<section class="container"> | ||
<div> | ||
<h2> | ||
Home | ||
</h2> | ||
<h2> | ||
<a href="about.html">About</a> | ||
</h2> | ||
<h2> | ||
<a href = "portfolio.html">Portfolio</a> | ||
</h2> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should be inside of a header tag and nav tag.
<h1> | ||
My Personal Portfolio | ||
</h1> | ||
<section class="container"> | ||
<div> | ||
<h2> | ||
Home | ||
</h2> | ||
<h2> | ||
<a href="about.html">About</a> | ||
</h2> | ||
<h2> | ||
<a href = "portfolio.html">Portfolio</a> | ||
</h2> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should be inside of a header tag and nav tag.
</div> | ||
<img | ||
alt= "Baby Photos" src = "/images/Baby-Photos.jpg" > | ||
<div class = "purple" > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of div tags you want to use section tags here. Here is a link to an article describing the difference between the two. https://www.geeksforgeeks.org/what-is-the-difference-between-section-and-div-tags-in-html/
<a href="index.html">Home</a> | ||
<a href="about.html">About</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be in a header and nav tag at the top of your page
</section> | ||
<footer> | ||
<div class = "purple" > | ||
<nav>This is my Nav bar.</nav> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be at the top of your page in a header tag
@@ -0,0 +1,34 @@ | |||
nav{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would take a look at this example from W3 schools. It shows a basic html template with css. It shows you a header, body, and footer with styling. https://www.w3schools.com/w3css/tryit.asp?filename=tryw3css_containers_semantic_article
… to personal projects
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions