Sea Turtles Natalia Woodson #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jun 30, 2022
| const [localTextColor, setLocalTextColor] = useState('black'); | ||
| const [remoteTextColor, setRemoteTextColor] = useState('black'); | ||
|
|
||
| const updateChatData = (updatedEntry) => { |
Comment on lines
+42
to
+47
| id: PropTypes.number.isRequired, | ||
| sender: PropTypes.string, | ||
| body: PropTypes.string, | ||
| timestamp: PropTypes.string, | ||
| liked: PropTypes.bool, | ||
| onUpdate: PropTypes.func.isRequired, |
There was a problem hiding this comment.
In Learn, we are seeing errors for some of your propTypes. I would only use isRequired on the props that must be passed for the component to render to pass the tests. In this case, the only required props would be the sender, body, timeStamp props.
| import PropTypes from 'prop-types'; | ||
|
|
||
| const ChatLog = (props) => { | ||
| const chatEntries = props.entries.map((entry) => { |
There was a problem hiding this comment.
you can use index with map. This should get rid of your key on each child error.
const chatEntries = prop.entries.map((entry, i) =>
...
<ChatEntry
key={i}|
|
||
| ChatLog.propTypes = { | ||
| entries: PropTypes.array.isRequired, | ||
| onUpdateChat: PropTypes.func.isRequired, |
There was a problem hiding this comment.
onUpdateChat is also giving a console error in learn. If you want this prop to be required then you could update the test to make sure it covers this prop as well or you can make it not required.
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| const ColorChoice = (props) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.