Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Polygon drawing functions #406

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

occamsshavingkit
Copy link

I added the public functions:
drawPolygon: draw lines between a list of points, connect the last and first points.
fillPolygon: draw lines between a list of points, fill in what is "inside" the shape.
drawRegPolygon: draw a regular polygon at a center point with a given radius and rotation about its center point. fillRegPolygon: fill a regular polygon like above.

and private helper functions:
sign: returns -1, 0, or 1 depending on the sign of its argument
isRelevant: determines if a given line is relevant for coloring a given point.

all to Adafruit_GFX.h and Adafruit_GFX.cpp

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.
    This will help us understand any risks of integrating
    the code.

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it.

  • Please run any tests or examples that can exercise your modified code. We
    strive to not break users of the code and running tests/examples helps with this
    process.

Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).

Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.

After reviewing the guidelines above you can delete this text from the pull request.

I added the public functions:
drawPolygon: draw lines between a list of points, connect the last and first points.
fillPolygon: draw lines between a list of points, fill in what is "inside" the shape.
drawRegPolygon: draw a regular polygon at a center point with a given radius and rotation about its center point.
fillRegPolygon: fill a regular polygon like above.
and private helper functions:
sign: returns -1, 0, or 1 depending on the sign of its argument
isRelevant: determines if a given line is relevant for coloring a given point.
stdarg.h to get the library to compile. Fixed poorly handled edge cases for isRelevant
no logic changes
more clang errors
more clang changes.
documentation for the regPolyType enum.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant