Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Adafruit_GFX.cpp #432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Adafruit_GFX.cpp #432

wants to merge 1 commit into from

Conversation

mroobol6
Copy link

*** CHANGED ***
#ifndef pgm_read_byte
#define pgm_read_byte(addr) (*(const unsigned char *)(addr)) #endif

*** TO - for use in Particle Photon ***
// #ifndef pgm_read_byte
#undef pgm_read_byte
#define pgm_read_byte(addr) (*(const unsigned char *)(addr)) // #endif

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

  • Describe the scope of your change--i.e. what the change does and what parts
    of the code were modified.
    This will help us understand any risks of integrating
    the code.

  • Describe any known limitations with your change. For example if the change
    doesn't apply to a supported platform of the library please mention it.

  • Please run any tests or examples that can exercise your modified code. We
    strive to not break users of the code and running tests/examples helps with this
    process.

Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).

Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.

After reviewing the guidelines above you can delete this text from the pull request.

*** CHANGED ***
#ifndef pgm_read_byte
#define pgm_read_byte(addr) (*(const unsigned char *)(addr))
#endif

*** TO - for use in Particle Photon ***
// #ifndef pgm_read_byte
#undef pgm_read_byte
#define pgm_read_byte(addr) (*(const unsigned char *)(addr))
// #endif
@mroobol6 mroobol6 marked this pull request as draft September 16, 2023 21:33
@mroobol6 mroobol6 marked this pull request as ready for review September 16, 2023 21:34
Copy link
Author

@mroobol6 mroobol6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@BillyDonahue
Copy link
Contributor

BillyDonahue commented Sep 21, 2023

This would break Arduino AVR, historically the most important platform for GFX.

This change is undefining special macros that the system headers (implicitly included by Arduino AVR) would have defined. The existing code would only define these macros if the system had not yet done so, and so it defined them with a cast that didn't consider PROGMEM storage.

PS: Title and description should be updated as well, per the boilerplate guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants