-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added public functions for button label and button enable/disable. #438
Open
ihakov2
wants to merge
16
commits into
adafruit:master
Choose a base branch
from
ihakov2:GetSetButtonLabel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihakov2
changed the title
Added public methods for button label
Added public functions for button label and button enable/disable.
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is
1. To reuse GFX_button object for On/Off Start/Stop operations
to save memory and convenience.
2. Set Enable/Disable button to check for click and process or skip (ignore) 'button click' checking and processing.
When the button is disabled it will keep currstate of the button as false
No limitation.
Test:
void loop() {
startButton.drawButton(true);//simulated click
delay(400);
if(started) {
startButton.setLabel("Stop");
configButton.setEnabled(false, ILI9341_LIGHTGREY);
}else { // not started
startButton.setLabel("Start");
configButton.setEnabled(true, ILI9341_BLUE);
}
Serial.print(F("\nstartButtonLabel="));Serial.println(startButton.getLabel());
Serial.println(configButton.isEnabled()? "configButton is Enabled":"configButton is Disabled");
started=!started;
delay(2000);
}
Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).
Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.
After reviewing the guidelines above you can delete this text from the pull request.