Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added public functions for button label and button enable/disable. #438

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

ihakov2
Copy link

@ihakov2 ihakov2 commented Oct 25, 2023

The purpose of this PR is
1. To reuse GFX_button object for On/Off Start/Stop operations
to save memory and convenience.
2. Set Enable/Disable button to check for click and process or skip (ignore) 'button click' checking and processing.
When the button is disabled it will keep currstate of the button as false
No limitation.

Test:
void loop() {
startButton.drawButton(true);//simulated click
delay(400);

if(started) {
startButton.setLabel("Stop");
configButton.setEnabled(false, ILI9341_LIGHTGREY);
}else { // not started
startButton.setLabel("Start");
configButton.setEnabled(true, ILI9341_BLUE);
}
Serial.print(F("\nstartButtonLabel="));Serial.println(startButton.getLabel());
Serial.println(configButton.isEnabled()? "configButton is Enabled":"configButton is Disabled");
started=!started;
delay(2000);
}

Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).

Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.

After reviewing the guidelines above you can delete this text from the pull request.

@ihakov2 ihakov2 marked this pull request as draft October 26, 2023 20:12
@ihakov2 ihakov2 changed the title Added public methods for button label Added public functions for button label and button enable/disable. Oct 26, 2023
@ihakov2 ihakov2 marked this pull request as ready for review October 27, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant