Gps parse improvements #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the current implementation of the parse() method to scan the entire sentence and count the fields before attempting to read the fields. This prevents accidental invalid pointer accesses when parsing invalid sentences with valid checksums. The new parse implementation also has a smaller compiled size. Includes a sketch in the "extras" directory (ignored by the Arduino IDE according to the library spec) that was used for testing the parsing of all sentences known to the parser.
Implementation of isEmpty() was incorrect since it performed a null check after dereferencing the pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issues #128 #153 and #154
It has been thoroughly tested and creates a smaller footprint than the original parser, so it should
not cause issues with the Arduino Uno.
Compiling GPS_SoftwareSerial_Parsing for Arduino Uno before refactor:
Compiling GPS_SoftwareSerial_Parsing for Arduino Uno after refactor: