-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add I2SInOut library #227
Add I2SInOut library #227
Conversation
I asked about the naming of this library during the weekly meeting today. The consensus was that it would be good to change the name slightly, but not necessarily due to possible conflict with a future core module. Can you rename the module to |
We also discussed helpers vs. drivers a bit, I think helpers is most appropriate for this library, though this one does sit sort of in the middle in that it's code that interfaces with hardware, but since it supports more than a single device helpers is more appropriate. PIO_UART was added under |
I love the suggestions, @FoamyGuy ! I'll make those adjustments soon to the library to get it more consistent with the practices of PIO_UART. |
… from drivers to helpers.
@FoamyGuy The library has been updated accordingly. The only additional change is that I removed "InOut" as to more closely match PIO_UART. Usage is now |
@relic-se I had a look in the actions log, it looks like the bundle build did not succeed because it found commits newer than the latest release in the new repo. When you have a chance can you make a new release in https://github.com/relic-se/CircuitPython_PIO_I2S, I think it should be able to pass after that. |
@FoamyGuy Gotcha. I've got a new release published: https://github.com/relic-se/CircuitPython_PIO_I2S/releases/tag/1.1.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
A general purpose driver for I2S devices. Allows read-only and bidirectional operation. Write-only operation is allowed as well, but not recommended in lieu of
audiobusio.I2SOut
. Requires CircuitPython 9.2.1.Because this library doesn't operate for a single device, it may be better placed within helpers. I'm also open to renaming this library in case it may create confusion with future additions to the CircuitPython core.