Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress our zips #109

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Compress our zips #109

merged 2 commits into from
Dec 19, 2023

Conversation

jepler
Copy link
Member

@jepler jepler commented Dec 19, 2023

This saves ~50% on regular bundles and will save ~85% on the font bundle.

This also changes how the fetch is done (from shallow to blobless) so that we're sure to have tags. I noticed during builds in my branch that CI warned about missing tags.

this should fix the message during CI
```
.../setuptools_scm/git.py:163: UserWarning: "/home/runner/work/circuitpython-build-tools/circuitpython-build-tools" is shallow and may cause errors
  warnings.warn(f'"{wd.path}" is shallow and may cause errors')
```

This may have been introduced when upgrading action/checkout recently,
or it might be pre-existing.
This saves ~50% on the main bundle and will save ~85% on the fonts bundle
@jepler jepler requested review from dhalbert and a team December 19, 2023 17:25
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@dhalbert dhalbert merged commit c6ebe5e into adafruit:main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants