Fix generation of dependencies[] array #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most often I find that I want to check just one kind of artifact (e.g., mpy files) and this is a quicker syntax than excluding the other 3 types with 3 --ignores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #112. I introduced the problem in #110. No internal dependencies were noticed, and these items were listed under external_dependencies instead.
This in turn affected the screenshot builder & bundlefly.
With the bug, the json data about pycamera looks like this:
{ "dependencies": [], "external_dependencies": [ "adafruit-circuitpython-aw9523", "adafruit-circuitpython-busdevice", "adafruit-circuitpython-debouncer", "adafruit-circuitpython-display-text", "adafruit-circuitpython-lis3dh", "adafruit-circuitpython-neopixel" ], "package": true, "path": "lib/adafruit_pycamera", "pypi_name": "adafruit-circuitpython-pycamera", "repo": "https://github.com/adafruit/adafruit_circuitpython_pycamera", "version": "0.0.7" }it should look like this:
{ "dependencies": [ "adafruit_aw9523", "adafruit_bus_device", "adafruit_debouncer", "adafruit_display_text", "adafruit_lis3dh", "neopixel" ], "external_dependencies": [], "package": true, "path": "lib/adafruit_pycamera", "pypi_name": "adafruit-circuitpython-pycamera", "repo": "https://github.com/adafruit/adafruit_circuitpython_pycamera", "version": "0.0.7" }