Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding read-only mode where user cannot pick a date #69

Closed
wants to merge 2 commits into from
Closed

Adding read-only mode where user cannot pick a date #69

wants to merge 2 commits into from

Conversation

JayHuang
Copy link

Adding read-only option: read-only="true"

This makes the directive not trigger the popup, preventing the user from selecting a date.

See bottom form, data updates according to the model using $watch, but user cannot manually edit End Date.

@JayHuang JayHuang closed this Jul 24, 2014
@JayHuang JayHuang deleted the readOnly branch July 24, 2014 16:39
@JayHuang JayHuang restored the readOnly branch July 24, 2014 16:42
@JayHuang JayHuang reopened this Jul 24, 2014
@JayHuang
Copy link
Author

Calendar still toggles for this version on tab focus, update coming.

Edit: Updated, see commit below.

@novarac23
Copy link
Collaborator

@JayHuang Hey mate! This looks like an interesting feature and I think I would like to merge it to master 👍 But I see there are some conflicts, do you mind taking a look at those ? I am willing to do pair programming if needed to fix these :)

@JayHuang
Copy link
Author

JayHuang commented Apr 9, 2016

@novarac23 I don't use ngQuickDate anymore, but I have created a new fork and submitted the same PR at #119 with conflicts resolved (dist files).

Worth noting that ngQuickDate is failing 8 tests, but this occurs regardless of the changes in my PR.

@novarac23
Copy link
Collaborator

@JayHuang Ok cool!

Closing this pr and gonna reference #119 for the fix! Thanks a lot for the effort mate! 🙌

@novarac23 novarac23 closed this May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants