Account code regeneration major performance improvement #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should drastically speed up the generation of full account codes.
The old:
O(n**2)
operationThe new:
NULL
or""
will cause all child full account codes to beNULL
.Caveat:
I've not ported this optimisation to. @Joshun, if you're still around I'd very much welcome your assistance here (or anyone else for that matter). Lack of this wont block merging though. Update: done, grumbles.mysql
And tagging @PetrDlouhy (#40), FYI.