Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
ratio_split()
distributes any change left after rounding to the last participant.This causes two minor issues:
ratio == 0
may still end up receiving change (debit or credit)This PR fixes this by using the Largest Remainder method to allocate change between participants with a
ratio != 0
.It also fixes a further problem whereby
ratio_split()
assumedDECIMAL_PLACES=2
.