-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Proxy Protocol. #428
Open
gautam142857
wants to merge
37
commits into
adamfisk:master
Choose a base branch
from
gautam142857:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tral release of this fork
…nager Made client details available to ChainedProxyManager
Library updates from JockX
Jockx library updates
This reverts commit adeb66f.
Refactor mitm manager to accept engine with user-defined parameters
Add ability to load keystore from classpath
This is useful for Services that are fronted by little proxy, but do not want the client's ip address to be obscured because the server's business logic involves using the client's ip address. https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt The feature is controlled by two options in the DefaultHttpProxyServer class : 1) sendProxy - to send a proxy protocol header to server 2) acceptProxy - to accept one from client Based on these configurations, a proxy protocol message decoder and encoder is added in ClientToProxyConnection and ProxyToServerConnection classes respectively. The default values of these configurations is false. Tests : Existing tests passed. Unit tests added for send, accept and relay proxy header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for Services that are fronted by little
proxy, but do not want the client's ip address to be
obscured because the server's business logic involves
using the client's ip address.
https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt
The feature is controlled by two options in the
DefaultHttpProxyServer class :
Based on these configurations, a proxy protocol message
decoder and encoder is added in ClientToProxyConnection
and ProxyToServerConnection classes respectively.
The changes are non-intrusive as the default values of these
configurations is false. One must specify these configurations
explicitly to work in the proxy protocol mode.
Tests :
Existing tests passed.
Unit tests added for send, accept and relay proxy header
Manually tested with HAProxy load balancer.