Allow multiple terminals in one notebook #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple xterms in one notebook. They can't all work at once - I couldn't manage to get that working - but it means if you have two cells with
%xtermin them, then you can run one, use the terminal a bit, then run the other. When you run the second one, the first terminal will automatically close, and the second one will become active.I've also added a manual 'close' button to the terminal interface.
This works particularly well with #5 and in the context of notebook-based documentation/training. You can have a paragraph of explanation, then a cell with
%xterm command-to-run --argsin it. The user can run that and interact with the terminal, then move on to more paragraphs of explanation below, and then another%xterm different-command --argscell, which they can also run to interact with that terminal.