Improve JSON #8
Open
Improve JSON #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added PEP 8 compliance to both scripts for improved readability and maintainability. Enhanced inline documentation for better code understanding. Optimized key removal and translation processes for efficiency. Truncated messages dynamically to fit terminal width. Improved error handling during JSON processing and translations. Added sorting and deduplication for discovered target languages. Ensured compatibility with dynamic directory structures.
adamlui
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Your edits affected the translate-en-messages.py but the code you added is for remove-json-keys.py, also can you edit the relevant file @ https://github.com/adamlui/python-utils instead (will auto-sync to here + other repos that use it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PEP 8 compliance to both scripts for improved readability and maintainability.
Enhanced inline documentation for better code understanding.
Optimized key removal and translation processes for efficiency.
Truncated messages dynamically to fit terminal width.
Improved error handling during JSON processing and translations.
Added sorting and deduplication for discovered target languages. Ensured compatibility with dynamic directory structures.