Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Add support for intersection to BloomFilter. #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

b4hand
Copy link
Contributor

@b4hand b4hand commented May 16, 2017

I realize that intersection will have the false positive rate of the maximum of the false positive rates of the intersected bloom filters, but this is a useful feature. You already provide support for unions via the merge method.

One concerning thing about the existing union support is that it doesn't check the size of the underlying bitset. This should probably be added to the checks for compatibility purposes before performing a merge. Similarly, it would be nice to add that check for intersection as well.

I'm willing to add code for isCompatible or similar to confirm compatibility before doing merges or intersection if you will allow that change.

@b4hand
Copy link
Contributor Author

b4hand commented May 16, 2017

Build is failing for the same reason as #133 which is more evidence that it is unrelated to this code.

@b4hand
Copy link
Contributor Author

b4hand commented May 16, 2017

Looking at the build history #108 has the same build failure as well, so it seems highly unlikely that the build failure is due to this code.

@b4hand b4hand force-pushed the add-intersection branch from e30f69b to 5620c2c Compare May 30, 2017 19:37
@b4hand
Copy link
Contributor Author

b4hand commented May 30, 2017

I rebased to the latest master which drops the openjdk7 build, so the build now passes.

@abramsm
Copy link
Contributor

abramsm commented Jul 7, 2017

OK to close in favor of #136?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants