Merge pull request #565 from adessoSE/fix-powerbi-report-prefix-error

Fix PowerBI imports failing when Prefix doesn't start with 1010A
adessoSE · Feb 15, 2024 · a9d59e8 · a9d59e8
2 parents a38f187 + ef3f76a
commit a9d59e8
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/...porter/src/main/java/de/adesso/budgeteer/importer/powerbi/PowerBiWorkRecordsImporter.java b/...porter/src/main/java/de/adesso/budgeteer/importer/powerbi/PowerBiWorkRecordsImporter.java
@@ -138,7 +138,7 @@ private ImportedWorkRecord mapWorkRecord(
       int dateColumn,
       int hoursColumn) {
     var prefixedProjectId = row.getCell(projectIdColumn).getStringCellValue();
-    var projectId = prefixedProjectId.substring(prefixedProjectId.indexOf('A'));
+    var projectId = extractProjectId(prefixedProjectId);
     var projectName = row.getCell(projectNameColumn).getStringCellValue();
     var employee = row.getCell(employeeNameColumn).getStringCellValue();
     var date = row.getCell(dateColumn).getDateCellValue();
@@ -160,4 +160,12 @@ private List<String> mapSkippedRecord(Row row) {
   private boolean isInvoiceable(String value) {
     return "KV".equals(value);
   }
+
+  private String extractProjectId(String prefixedProjectId) {
+    var prefixIndex = prefixedProjectId.indexOf('A');
+    if (prefixIndex == -1) {
+      return prefixedProjectId;
+    }
+    return prefixedProjectId.substring(prefixIndex);
+  }
 }