Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup.sh): add separate s3 bucket functionality for kuberesources #88

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eyenx
Copy link
Member

@eyenx eyenx commented Jun 15, 2024

Partially fixes #83

Sets new OCP_BACKUP_KUBERESOURCSES_S3_* variables, to push kuberesources which may contain the encrypted keys for the etcd backup (if encryption is enabled on etcd) to a separate bucket.

Only works when using S3, not yet when only using local backup folder.

See https://docs.openshift.com/container-platform/4.12/backup_and_restore/control_plane_backup_and_restore/backing-up-etcd.html

If etcd encryption is enabled, it is recommended to store this second file separately from the etcd snapshot for security reasons. However, this file is required to restore from the etcd snapshot.

@eyenx
Copy link
Member Author

eyenx commented Sep 10, 2024

Not sure what the state of this is, therefore putting this on DRAFT

@eyenx eyenx marked this pull request as draft September 10, 2024 12:03
Copy link
Member

@tongpu tongpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine at first glance.

Is there a reason you switched to 4 spaces indentation or did you simply change your linter. 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: If ETCD is Encrypted, Store static_kuberesources.tgz on a Different Storage
2 participants