Display reports #150

kryswisnaskas · 2021-02-05T17:10:27Z

Description of change
Reports are displayed under "Activity Reports". In this PR the table contains all reports in smart hub. The UI contains a "New report" button that allows to create a new report. If there are no reports, an empty row will be displayed in the table.

How to test
Local:

pull changes
yarn deps
yarn db:migrate
yarn db:seed
yarn start:local
click on "Activity Reports"
verify the landing page has a table with "Activity reports"
create a couple of reports
verify they are displayed

Docker:

same as above, but with the docker commands

Issue(s)

Display list of Activity Reports HHS/Head-Start-TTADP#5

Checklist

Meets issue criteria
Code tested
Meets accessibility standards (WCAG 2.1 Levels A, AA)
Documentation updated
- API methods
- Boundary and Data Flow Diagrams
- Architectural Decision Records written for major infrastructure decisions with the Nygard template
- OSCAL templates completed when security controls are implemented or modified

Note - "Fix Cucumber tests" branch was merged in to potentially avoid cucumber test failures.

…into kw-display-reports

…eam/Head-Start-TTADP into kw-display-reports

…d-Start-TTADP into kw-display-reports

src/routes/activityReports/handlers.js

frontend/src/pages/Landing/index.js

…into kw-display-reports

jasalisbury

Looks good!

dcmcand

Nice job Krys!

rahearn · 2021-02-10T22:03:50Z

I'll do an in-depth review of this tomorrow morning, but I wanted to flag that when I run yarn docker:deps it's changing yarn.lock (the backend one). Please update that to be in-sync with package.json

rahearn

Nice stuff, Krys.

There's two minor accessibility concerns I have with the table, but the biggest issue is that I can't actually see the whole table on my laptop:

rahearn · 2021-02-11T15:14:09Z

frontend/src/components/LandingLayout.js

+
+function LandingLayout({ children }) {
+  return (
+    <Grid row>


Does this need a GridContainer around it?

The idea was to get away from the GridContainer due to layout constraints.

frontend/src/pages/Landing/__tests__/index.js

frontend/src/pages/Landing/index.js

src/models/user.js

…d-Start-TTADP into kw-display-reports

kryswisnaskas · 2021-02-12T17:55:57Z

What's the purpose of this test vs. the tests that validate each column individually? This feels like maybe it's over-specified

Removed this test.

Please switch this column to be a

Switched.

This is causing a 500 error when updating users with a null role.

Good catch!
Modified.

when I run yarn docker:deps it's changing yarn.lock (the backend one). Please update that to be in-sync with package.json

Updated.

kryswisnaskas · 2021-02-12T18:03:45Z

the biggest issue is that I can't actually see the whole table on my laptop:

I was going to handle that in a separate PR, but since it's already an issue, I added scrollbars now. This wasn't an attempt to hide the right side of the table.

rahearn

Code looks good, but the tests failures are consistent for whatever reason. Once that's cleaned up this'll be good to merge

commit 5896310 Merge: 55a2a37 c0394f1 Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 17:39:27 2021 -0500 Merge pull request #150 from adhocteam/kw-display-reports Display reports commit c0394f1 Merge: 9189f61 55a2a37 Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 17:13:40 2021 -0500 Merge branch 'main' into kw-display-reports commit 55a2a37 Merge: e985f60 61cb04e Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 17:11:28 2021 -0500 Merge pull request #163 from adhocteam/kw-secure-cookie Add explicit cookie-session options commit 61cb04e Merge: 4ba76a9 6740fd5 Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 16:56:17 2021 -0500 Merge branch 'kw-secure-cookie' of https://github.com/adhocteam/Head-Start-TTADP into kw-secure-cookie commit 4ba76a9 Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 16:55:58 2021 -0500 Remove one of secure cookie settings commit 6740fd5 Merge: fa3f81e e985f60 Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 16:54:01 2021 -0500 Merge branch 'main' into kw-secure-cookie commit 9189f61 Merge: c1f7ba4 e985f60 Author: Ryan Ahearn <[email protected]> Date: Fri Feb 12 14:23:56 2021 -0500 Merge branch 'main' into kw-display-reports commit c1f7ba4 Merge: f3881d1 79a4808 Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 12:57:14 2021 -0500 Merge branch 'main' into kw-display-reports commit f3881d1 Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 12:26:40 2021 -0500 Fix lint errors commit 112ccd6 Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 11:10:37 2021 -0500 Update yarn.lock commit cdc95f1 Merge: 1b1ce8c 8751dcf Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 10:18:13 2021 -0500 Merge branch 'kw-display-reports' of https://github.com/adhocteam/Head-Start-TTADP into kw-display-reports commit 1b1ce8c Author: kryswisnaskas <[email protected]> Date: Fri Feb 12 10:17:49 2021 -0500 Added scrollbars; removed test; modified styles commit fa3f81e Author: kryswisnaskas <[email protected]> Date: Wed Feb 10 16:22:08 2021 -0500 Add explicit cookie session options commit 8751dcf Merge: 3d8382b c5b47a7 Author: kryswisnaskas <[email protected]> Date: Wed Feb 10 12:51:09 2021 -0500 Merge branch 'main' into kw-display-reports commit 3d8382b Author: kryswisnaskas <[email protected]> Date: Wed Feb 10 12:25:43 2021 -0500 Fix merge issue commit 3d4b1ac Merge: 6c5e287 16c743f Author: kryswisnaskas <[email protected]> Date: Wed Feb 10 11:50:02 2021 -0500 Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP into kw-display-reports commit 6c5e287 Author: kryswisnaskas <[email protected]> Date: Wed Feb 10 11:46:58 2021 -0500 Remove blank lines commit ff3b8b5 Author: kryswisnaskas <[email protected]> Date: Wed Feb 10 11:21:03 2021 -0500 Remove sorting commit 1da28b0 Merge: c3b37b4 d1c5786 Author: kryswisnaskas <[email protected]> Date: Wed Feb 10 09:32:54 2021 -0500 Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP into kw-display-reports commit c3b37b4 Author: kryswisnaskas <[email protected]> Date: Tue Feb 9 17:47:17 2021 -0500 Adjust test commit 4af7bd8 Author: kryswisnaskas <[email protected]> Date: Tue Feb 9 17:33:38 2021 -0500 Remove whitespace to satisfy eslint commit 253e568 Author: kryswisnaskas <[email protected]> Date: Tue Feb 9 17:10:15 2021 -0500 Combine values from multiples commit 23cf654 Author: kryswisnaskas <[email protected]> Date: Tue Feb 9 14:31:56 2021 -0500 Fix new eslint errors commit e4e51ec Author: kryswisnaskas <[email protected]> Date: Tue Feb 9 14:31:34 2021 -0500 Fix new eslint errors commit 4b8a95d Author: kryswisnaskas <[email protected]> Date: Tue Feb 9 13:42:36 2021 -0500 Add role acronyms to display commit 809a57b Author: kryswisnaskas <[email protected]> Date: Tue Feb 9 12:23:42 2021 -0500 Update open api doc commit 55c78db Author: kryswisnaskas <[email protected]> Date: Tue Feb 9 09:02:27 2021 -0500 Fix cucumber test commit f106cc2 Author: kryswisnaskas <[email protected]> Date: Mon Feb 8 20:26:38 2021 -0500 Modified cucumber test commit a21b9d2 Author: kryswisnaskas <[email protected]> Date: Mon Feb 8 20:12:33 2021 -0500 Modified cucumber test commit 0561da4 Merge: 664b52f a99fe60 Author: kryswisnaskas <[email protected]> Date: Mon Feb 8 19:40:25 2021 -0500 Merge branch 'kw-display-reports' of https://github.com/adhocteam/Head-Start-TTADP into kw-display-reports commit 664b52f Merge: 158b2cd 0277d73 Author: kryswisnaskas <[email protected]> Date: Mon Feb 8 19:39:54 2021 -0500 Merge branch 'js-282-fix-cucumber-tests' of https://github.com/adhocteam/Head-Start-TTADP into kw-display-reports commit a99fe60 Merge: 158b2cd 9f5bb95 Author: kryswisnaskas <[email protected]> Date: Mon Feb 8 19:30:27 2021 -0500 Merge branch 'main' into kw-display-reports commit 158b2cd Author: kryswisnaskas <[email protected]> Date: Mon Feb 8 19:15:28 2021 -0500 Fix lint errors commit e4dae31 Author: kryswisnaskas <[email protected]> Date: Mon Feb 8 18:08:49 2021 -0500 Added more tests commit 04bba1c Author: kryswisnaskas <[email protected]> Date: Fri Feb 5 16:51:33 2021 -0500 Fix lint errors commit 95b3a38 Author: kryswisnaskas <[email protected]> Date: Fri Feb 5 15:05:51 2021 -0500 Fix merge conflict commit 7d9805f Merge: 4b6a542 5a31b94 Author: kryswisnaskas <[email protected]> Date: Fri Feb 5 14:39:14 2021 -0500 Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP into kw-display-reports commit 4b6a542 Author: kryswisnaskas <[email protected]> Date: Fri Feb 5 13:59:37 2021 -0500 Remove unused module commit 67566d3 Author: kryswisnaskas <[email protected]> Date: Fri Feb 5 13:58:32 2021 -0500 Fix lint errors commit 6de8f8e Author: kryswisnaskas <[email protected]> Date: Fri Feb 5 12:24:20 2021 -0500 Fix merge issue commit 6431825 Author: kryswisnaskas <[email protected]> Date: Fri Feb 5 11:48:46 2021 -0500 Correct merge error commit 75f7639 Author: kryswisnaskas <[email protected]> Date: Fri Feb 5 11:46:04 2021 -0500 Added tests, empty report commit 69ccf13 Merge: a2bd6c0 8e5d3ef Author: kryswisnaskas <[email protected]> Date: Wed Feb 3 17:18:26 2021 -0500 Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP into kw-display-reports commit a2bd6c0 Merge: a716599 4c3a436 Author: kryswisnaskas <[email protected]> Date: Sat Jan 30 10:07:19 2021 -0500 Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP into kw-display-reports commit a716599 Author: kryswisnaskas <[email protected]> Date: Fri Jan 29 13:50:53 2021 -0500 Added sorting commit cedfeb0 Author: kryswisnaskas <[email protected]> Date: Wed Jan 27 12:47:28 2021 -0500 Landing page checkpoint commit

kryswisnaskas and others added 20 commits January 27, 2021 12:47

Landing page checkpoint commit

cedfeb0

Added sorting

a716599

Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP …

a2bd6c0

…into kw-display-reports

Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP …

69ccf13

…into kw-display-reports

Added tests, empty report

75f7639

Correct merge error

6431825

Fix merge issue

6de8f8e

Fix lint errors

67566d3

Remove unused module

4b6a542

Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP …

7d9805f

…into kw-display-reports

Fix merge conflict

95b3a38

Fix lint errors

04bba1c

Added more tests

e4dae31

Fix lint errors

158b2cd

Merge branch 'main' into kw-display-reports

a99fe60

Merge branch 'js-282-fix-cucumber-tests' of https://github.com/adhoct…

664b52f

…eam/Head-Start-TTADP into kw-display-reports

Merge branch 'kw-display-reports' of https://github.com/adhocteam/Hea…

0561da4

…d-Start-TTADP into kw-display-reports

Modified cucumber test

a21b9d2

Modified cucumber test

f106cc2

Fix cucumber test

55c78db

kryswisnaskas requested review from dcloud, dcmcand, gopar and jasalisbury February 9, 2021 14:15

kryswisnaskas added 4 commits February 9, 2021 12:23

Update open api doc

809a57b

Add role acronyms to display

4b8a95d

Fix new eslint errors

e4e51ec

Fix new eslint errors

23cf654

jasalisbury reviewed Feb 9, 2021

View reviewed changes

src/routes/activityReports/handlers.js Show resolved Hide resolved

frontend/src/pages/Landing/index.js Show resolved Hide resolved

frontend/src/pages/Landing/index.js Outdated Show resolved Hide resolved

frontend/src/pages/Landing/index.js Outdated Show resolved Hide resolved

Combine values from multiples

253e568

kryswisnaskas added 7 commits February 9, 2021 17:33

Remove whitespace to satisfy eslint

4af7bd8

Adjust test

c3b37b4

Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP …

1da28b0

…into kw-display-reports

Remove sorting

ff3b8b5

Remove blank lines

6c5e287

Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP …

3d4b1ac

…into kw-display-reports

Fix merge issue

3d8382b

jasalisbury approved these changes Feb 10, 2021

View reviewed changes

Merge branch 'main' into kw-display-reports

8751dcf

kryswisnaskas requested a review from rahearn February 10, 2021 17:55

dcmcand approved these changes Feb 10, 2021

View reviewed changes

rahearn suggested changes Feb 11, 2021

View reviewed changes

rahearn mentioned this pull request Feb 11, 2021

Add displayId virtual field to activity reports #162

Merged

4 tasks

kryswisnaskas added 4 commits February 12, 2021 10:17

Added scrollbars; removed test; modified styles

1b1ce8c

Merge branch 'kw-display-reports' of https://github.com/adhocteam/Hea…

cdc95f1

…d-Start-TTADP into kw-display-reports

Update yarn.lock

112ccd6

Fix lint errors

f3881d1

Merge branch 'main' into kw-display-reports

c1f7ba4

Merge branch 'main' into kw-display-reports

9189f61

rahearn approved these changes Feb 12, 2021

View reviewed changes

Merge branch 'main' into kw-display-reports

c0394f1

kryswisnaskas merged commit 5896310 into main Feb 12, 2021

kryswisnaskas deleted the kw-display-reports branch February 12, 2021 22:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display reports #150

Display reports #150

kryswisnaskas commented Feb 5, 2021 •

edited

Loading

jasalisbury left a comment

dcmcand left a comment

rahearn commented Feb 10, 2021

rahearn left a comment

rahearn Feb 11, 2021

kryswisnaskas Feb 12, 2021

kryswisnaskas commented Feb 12, 2021

kryswisnaskas commented Feb 12, 2021

rahearn left a comment

Display reports #150

Display reports #150

Conversation

kryswisnaskas commented Feb 5, 2021 • edited Loading

jasalisbury left a comment

Choose a reason for hiding this comment

dcmcand left a comment

Choose a reason for hiding this comment

rahearn commented Feb 10, 2021

rahearn left a comment

Choose a reason for hiding this comment

rahearn Feb 11, 2021

Choose a reason for hiding this comment

kryswisnaskas Feb 12, 2021

Choose a reason for hiding this comment

kryswisnaskas commented Feb 12, 2021

kryswisnaskas commented Feb 12, 2021

rahearn left a comment

Choose a reason for hiding this comment

kryswisnaskas commented Feb 5, 2021 •

edited

Loading