Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: adding macOs runner with docker setup #6

Closed
wants to merge 3 commits into from
Closed

ci: adding macOs runner with docker setup #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
661c2af
ci: adding macOs runner with docker setup
rH4rtinger Sep 20, 2024
f5114bb
test: updated some timeouts in tests
rH4rtinger Sep 20, 2024
c5221ca
test: updated timeouts once more for macOS runner
rH4rtinger Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
# Therefore, we can not install and start a docker container in the WSL.

# Currently, no macOS runner, because during the setup of docker, this runner hangs: https://github.com/douglascamata/setup-docker-macos-action/issues/37
os: [ubuntu-latest]
os: [ubuntu-latest, macos-13]
node-version: [18.x, 20.x, 22.x]
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -28,6 +28,10 @@ jobs:
java-version: 21
distribution: temurin

- name: Set up docker for macOS
if: runner.os == 'macOS'
uses: douglascamata/[email protected]

- name: Check Docker Version
run: docker --version

Expand Down
4 changes: 3 additions & 1 deletion src/test/suite/convertFormat.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ suite("convert format", () => {
*/
test(`should transform ${pArgument.format} with ${pArgument.fileSelection ? "file" : "folder"} ${
pArgument.changelogLocation
} ${typeof pArgument.changelogLocation !== "string" ? "selected from rmb" : ""}`, async () => {
} ${typeof pArgument.changelogLocation !== "string" ? "selected from rmb" : ""}`, async function () {
this.timeout(8000);

const infoMessage = TestUtils.createInfoMessageStubWithSelection();

await assertConverting(
Expand Down
2 changes: 1 addition & 1 deletion src/test/suite/extension.it.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ suite("Extension Integration Test Suite", () => {
* Also creates a properties file for the test.
*/
suiteSetup("init extension and properties file", async function () {
this.timeout(80_000);
this.timeout(300_000);

// start a maria db container and wait for its status
await DockerTestUtils.startContainer();
Expand Down
Loading