-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Release v2.19.0 #353
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reader and writer. Reader looks for orcId and maps to external identifier. Writer looks for external identifier with namespace ORCID and maps associated id to orcId. Both only work for contact type of person, disabled for organizations.
Add Reports Section
* fix key retrieval for Html_RangeElementDescription writer class * fix br in rangeElement
…me field for data quality.
hmaier-fws
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been published to test site for a long time with no complaints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142
Closes #222
Closes #243
Closes #240
Closes #249
Closes #255
Closes #289
Closes #260
Closes #291
Closes #292
Closes #293
Closes #294
Closes #303
Closes #304
Closes #305
Closes #314
Closes #323
Closes #320
Might close the following:
#145
#257
Testing
Track testing deployment state here
https://dev-mdtranslator.mdeditor.org/
Changes
Version 2.19.0 (beta.31)
Dependencies
Internal Object
Readers
fgdc
mdJson
sbJson
orcId
and maps toexternalIdentifiers[ { identifier: <orcId value>, namespace: "ORCID", description: "Open Researcher and Contributor Id" } ]
Writers
fgdc
html
iso19115-3
mdJson
sbJson
identifier
toorcId
simple-html
Fixed Unit Tests
reader - fgdc
reader - iso19115-3
writer - mdJson