Add bureauCode class to DCAT writer #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwaspin
approved these changes
May 9, 2024
hmaier-fws
pushed a commit
that referenced
this pull request
Dec 10, 2024
* 264 dcat us writer required fields (#274) * Add DCAT-US Writer Migrating changes from another branch. Unit tests and writers for most required fields and some if-applicable fileds. * Add DCAT-US.md * Remove Whitespace * New Access Level Unit Test Fix accessLevel writer. * Add Unit Tests Access Level New tests for public and restricted public. * New Unit Test For License * New Unit Test Spatial * Remove Comment Headers * New Temporal Unit Test * Remove Comment Header * Add DCAT-US Tests to Rakefile * Update MiniTest to Minitest * New Distribution Unit Test * Complete Temporal Unit Test & Writer * Update Rights Unit Test & Writer * Remove Sample Files * 269 dcat us writer optional fields (#282) * Add DCAT-US Writer Migrating changes from another branch. Unit tests and writers for most required fields and some if-applicable fileds. * Add DCAT-US.md * Remove Whitespace * New Access Level Unit Test Fix accessLevel writer. * Add Unit Tests Access Level New tests for public and restricted public. * New Unit Test For License * New Unit Test Spatial * Remove Comment Headers * New Temporal Unit Test * Remove Comment Header * Add DCAT-US Tests to Rakefile * Update MiniTest to Minitest * New Distribution Unit Test * Complete Temporal Unit Test & Writer * Update Rights Unit Test & Writer * Remove Sample Files * New Issued Field Writer, unit test, and test file. Enabled issue field in main dcat_us writer. * New Theme Field Writer, unit test, and test file. Enabled theme in main dcat_us writer. * New Landing Page Field Writer, unit test, and test file. Enabled landingPage in main writer. * New IsPartOf Field Writer, unit test, and test file. Enabled isPartOf in main writer. * Update DCAT-US.md * New Described By Field Writer, unit test, and test file. Enabled describedBy in the main writer. * New References Field Writer, unit test, and test file. Enabled references field in main writer. * New System of Records Field Writer, unit test, and test file. Enabled systemOfRecords field in main writer. * Update description mapping * Update test data * Enable Fields * Fix Conditional includedWithDataset is the internal version of the dictionaryIncludedWithResource field in mdJson. * Fix Description Moved into its own file and fixed the mapping. * Update version * Add sbJson External Contact Identifiers Reader and writer. Reader looks for orcId and maps to external identifier. Writer looks for external identifier with namespace ORCID and maps associated id to orcId. Both only work for contact type of person, disabled for organizations. * Update Version * Add Data Quality Reports Array * Fix internal metadata object * Cleanup & Fix * Fix Data Quality Reader - mdJson * Cleanup * Fix Data Quality * Implement Data Quality Report * Implement Coverage Result - mdJson writer * Fix & Cleanup Data Quality * Fix Spatial Representation * Fix HTML citation Writer * Cleanup * Update Version * Update Version * Fix Internal Metadata Object - Data Quality Coverage Result * Fix Refereence Typo * Add Data Quality Link * Handle Empty Citation * Improve Data Quality Add Reports Section * Implement Data Quality Reports * Add Null Checks * Handle nil and empty * Handle nil & empty * New Generator newRangeElementDescription * close out function * fix reader to recognize rangeElement key from mdJson file (#317) * fix key retrieval for Html_RangeElementDescription writer class (#318) * fix key retrieval for Html_RangeElementDescription writer class * fix br in rangeElement * fix rangeElementDescription class for iso-3 (#321) * add contact - external identifiers * Fix Simple HTML and mdJson hash objects rangeElements -> rangeElement * Fix misplaced br tag * make changes based on feedback found in release v2.18.5 branch (#325) * make changes based on feedback found in release v2.18.5 branch * Fix evaluationMethod in mdJson * remove extra argument * Revert Changes * Reorder and Add derivedElementReport * Add Report Fields type standaloneQualityReportDetails * Change dateTime to array * Revert * Add standaloneQualityReportDetails * Add derivedElementReport * add posacc w hori and vert tags. fix key retrieval from qualityMeasure (#327) * Update Gemfile.lock * Dcat us v1/cleanup (#326) * Updated Gemfile to work with tests. Added test documentation. * Added github action to run automated tests * Updated DCAT-US to not use namespace See examples of what DCAT-US and data.gov expect here: https://github.com/GSA/ckanext-datajson/tree/main/ckanext/datajson/tests/datajson-samples * New GitHub Test Action (#328) This merge is not intended to have the tests passing yet, just adding the test action workflow file. * Bugfix/unit tests (#329) * Update Internal Object * Fix Data Quality Order * Fix Data Quality Order * Fixing Legal Constraint Order * Fix Allocation Order * Fix Funding Order * Fix Data Quality Order * Update Data Quality Object * And standaloneQualityReportDetails to mdJson Reader * Fix Order * Fix Standalone Quality Report * Update Version for mdJson-schemas * Add Quality Result File to Coverage Result * Update Gemfile.lock * Update nokogiri * Rename standaloneQualityReport.rb Need to fix naming case. * Fix File Name * Fix Typo * Fix Internal Object resultContent --> resultContentDescription and { } not [ ] * Completed Feature: Coverage Result (#330) * Add Quality Result File to Coverage Result * add resultFile to coverageResult in mdJson reader (#331) * add resultFile to coverageResult in mdJson reader * remove pp lib * revert files * generate resourceFormat file and add to CR. fix metadata object in resultFile * fix internal metadata obj in resultFile * fix qualityResultFile class and reference * revert files * fix relative import * remove writer changes * Remove module_resourceFormat * Injection/md json writer cr (#332) * rename to qualityResultFile * add format and QualityResultFile classes to coverageResult in writer * revert files * add qualityResultFile * Fixed Names fileName was repeated in place of fileDescription and fileType. * Fix Result Content resultContent -> resultContentDescription Uses coverageDescription * Change nil? to empty? --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * Injection/html writer cr (#336) * add qualityMeasure to mdJson reader * fix qualityMeasure key * add resultFile class to dataQualityReport html writer * Fix Quality Measure Identifier needs to be built not directly assigned. * Improve Quality Measure Name and description will only be populated if they exist. --------- Co-authored-by: Jonathan Oliveros <[email protected]> * Injection/simple html writer cr (#335) * add dataQualityReport and resultFile classes * fix file format comment * reference resultFile class * change details to div * change details to div in dataQualityReport * change module to simple_html. Add nil or empty to citation within identifier. * add simple_html test * Add Coverage Result New class_qualityResultFile for iso19115-3 writer. * Fix Data Quality Report Fixed the order. Fixed quality measure. * Fix Quality Measure * Fix Quality Measure * Fix Evaluation Method * New Conformance Result ISO 19115-3 Writer --------- Co-authored-by: J-Oliveros <[email protected]> Co-authored-by: Jonathan Oliveros <[email protected]> * Increment Minor Version * Update Version * Revert Changes * Revert Changes * Revert Changes * Revert Changes * Remove nil Check Including the check for nil can actually cause errors. If there is an error then the problem is somewhere else. * Remove nil Check Should not check for nil, if it is nil then there's a problem with the reader. * Revert Changes * change divs to headers (#337) * change divs to headers * fix key within qualityMeasure. change to header tags * Update mdCodes Version * Update Gemfile.lock * Fix Data Quality fgdc reader needed some refactoring. Added/fixed checks for nil/empty. * Fix name -> nameOfMeasure * Increment Patch Version * Fix FGDC Reader quantitativeResult was being set to the qualityMeasure and using the qualityMeasure object. Fixed to use the correct object and location. * Fix Data Quality (#342) * Increment Patch Version * Simple HTML Enhancements (#339) * add geographicExtent to simple_html writer (#338) * add geographicExtent to simple_html writer * Fix Data Quality Fixed checks for nil and empty. Fixed tags. Fixed structures. * Fix Data Quality * Remove bodyScript and other js * Fix Typo referenceDocument -> referenceDocuments --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * add bookmark span tags to headers (#340) Co-authored-by: Johnathan Aspinwall <[email protected]> * Increment Patch Version * Increment Minor Version --------- Co-authored-by: J-Oliveros <[email protected]> * Bugfixes for Simple HTML (#343) * change divs to headers (#337) * change divs to headers * fix key within qualityMeasure. change to header tags * Simple HTML Enhancements (#339) * add geographicExtent to simple_html writer (#338) * add geographicExtent to simple_html writer * Fix Data Quality Fixed checks for nil and empty. Fixed tags. Fixed structures. * Fix Data Quality * Remove bodyScript and other js * Fix Typo referenceDocument -> referenceDocuments --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * add bookmark span tags to headers (#340) Co-authored-by: Johnathan Aspinwall <[email protected]> * Increment Patch Version * Increment Minor Version --------- Co-authored-by: J-Oliveros <[email protected]> --------- Co-authored-by: J-Oliveros <[email protected]> * Increment Patch Version * Fix Data Quality * Increment Patch Version * Feature/simple html (#345) * add geographicExtent to simple_html writer (#338) * add geographicExtent to simple_html writer * Fix Data Quality Fixed checks for nil and empty. Fixed tags. Fixed structures. * Fix Data Quality * Remove bodyScript and other js * Fix Typo referenceDocument -> referenceDocuments --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * add bookmark span tags to headers (#340) Co-authored-by: Johnathan Aspinwall <[email protected]> * Increment Patch Version * Increment Minor Version * Bugfixes for Simple HTML (#343) * change divs to headers (#337) * change divs to headers * fix key within qualityMeasure. change to header tags * Simple HTML Enhancements (#339) * add geographicExtent to simple_html writer (#338) * add geographicExtent to simple_html writer * Fix Data Quality Fixed checks for nil and empty. Fixed tags. Fixed structures. * Fix Data Quality * Remove bodyScript and other js * Fix Typo referenceDocument -> referenceDocuments --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * add bookmark span tags to headers (#340) Co-authored-by: Johnathan Aspinwall <[email protected]> * Increment Patch Version * Increment Minor Version --------- Co-authored-by: J-Oliveros <[email protected]> --------- Co-authored-by: J-Oliveros <[email protected]> * Increment Patch Version * Fix Data Quality * Increment Patch Version * simple_html output formatting (#344) --------- Co-authored-by: J-Oliveros <[email protected]> * Update mdJson-schemas version mdJson-schemas -> 2.8.3 * Increment Patch Version * Feature/fgdc reader lineage process (#347) * add references to process * redirect citation to processSteps * revert to lineageCitation * Fix newLineage Order dataSources after processSteps * Moving Methodology to Process Steps * Restore hResourceInfo Variable * Commented Keyword - Method Required Warning * Upgrade adiwg-mdjson_schemas adiwg-mdjson_schemas -> 2.9.0 * Update Gemfile.lock * commented out mdJson reader minor version test * Refactor lineage module and process module. Updated tests. * Add comment about test being disabled. * Add comment to explain why code is disabled --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * Update mdtranslator version to 2.20.0 * Update ruby/setup-ruby version in test.yml * Update adiwg-mdtranslator and adiwg-mdjson_schemas versions * Update mdtranslator version to 2.21.0 * Update adiwg-mdtranslator gem dependencies * Update adiwg-mdcodes gem dependency to version 2.9.1 * Disable test_mdJson_reader_schema_version_future_minor method * Update mdtranslator version to 2.19.0-beta.6 * Update adiwg-mdcodes gem dependency to version 2.9.1 * Fix data quality report type Remove DQ_ prefix. * Add mapping to accessLevel (#352) * Add mapping to accessLevel * Formatting * Update tests to reflect mapping * remove unnecessary print statement * fix legal and security accessLevel codes in tests * Add test cases for accessLevel. fix array append to accessLevelCodes. * Add language support to DCAT-US writer (#349) * Update accrualPeriodicity field in DCAT-US writer (#350) * Update accrualPeriodicity field in DCAT-US writer * Break out accrualPeriodicity and add mapping * add nil check to frequency * Add primaryITInvestmentUII in DCAT-US writer (#351) * Add primaryITInvestmentUII in DCAT-US writer * add support for primaryITInvestmentUII --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * Update mdtranslator version to 2.19.0-beta.7 * Update adiwg-mdjson_schemas and adiwg-mdcodes gem dependencies * Update adiwg-mdjson_schemas and adiwg-mdcodes gem dependencies * Add support to describedByType in DCAT-US writer (#355) * Add AccessURL, DownloadURL, and MediaType modules to DCAT-US writer (#354) * Release Version 2.20.0 (#346) * change divs to headers (#337) * change divs to headers * fix key within qualityMeasure. change to header tags * Simple HTML Enhancements (#339) * add geographicExtent to simple_html writer (#338) * add geographicExtent to simple_html writer * Fix Data Quality Fixed checks for nil and empty. Fixed tags. Fixed structures. * Fix Data Quality * Remove bodyScript and other js * Fix Typo referenceDocument -> referenceDocuments --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * add bookmark span tags to headers (#340) Co-authored-by: Johnathan Aspinwall <[email protected]> * Increment Patch Version * Increment Minor Version --------- Co-authored-by: J-Oliveros <[email protected]> * Feature/simple html (#345) * add geographicExtent to simple_html writer (#338) * add geographicExtent to simple_html writer * Fix Data Quality Fixed checks for nil and empty. Fixed tags. Fixed structures. * Fix Data Quality * Remove bodyScript and other js * Fix Typo referenceDocument -> referenceDocuments --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * add bookmark span tags to headers (#340) Co-authored-by: Johnathan Aspinwall <[email protected]> * Increment Patch Version * Increment Minor Version * Bugfixes for Simple HTML (#343) * change divs to headers (#337) * change divs to headers * fix key within qualityMeasure. change to header tags * Simple HTML Enhancements (#339) * add geographicExtent to simple_html writer (#338) * add geographicExtent to simple_html writer * Fix Data Quality Fixed checks for nil and empty. Fixed tags. Fixed structures. * Fix Data Quality * Remove bodyScript and other js * Fix Typo referenceDocument -> referenceDocuments --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * add bookmark span tags to headers (#340) Co-authored-by: Johnathan Aspinwall <[email protected]> * Increment Patch Version * Increment Minor Version --------- Co-authored-by: J-Oliveros <[email protected]> --------- Co-authored-by: J-Oliveros <[email protected]> * Increment Patch Version * Fix Data Quality * Increment Patch Version * simple_html output formatting (#344) --------- Co-authored-by: J-Oliveros <[email protected]> * Feature/fgdc reader lineage process (#347) * add references to process * redirect citation to processSteps * revert to lineageCitation * Fix newLineage Order dataSources after processSteps * Moving Methodology to Process Steps * Restore hResourceInfo Variable * Commented Keyword - Method Required Warning * Upgrade adiwg-mdjson_schemas adiwg-mdjson_schemas -> 2.9.0 * Update Gemfile.lock * commented out mdJson reader minor version test * Refactor lineage module and process module. Updated tests. * Add comment about test being disabled. * Add comment to explain why code is disabled --------- Co-authored-by: Johnathan Aspinwall <[email protected]> * Update 19115-3 test data (#334) * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * upate attributeGroup * update 19115_3_citation.xml * update 19115_3_constraintCommon.xml * update 19115_3_constraintCommon.xml and 19115_3_citation.xml * update 19115_3_dataIdentification.xml * update 19115_3_leProcessStep.xml * update 19115_3_maintenance.xml * update 19115_3_mdBand.xml * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update 19115-3 test data * Update remoteSchema URL in class_mdMetadata.rb * Add fix for 19115-3 writer in class_rangeElementDescription and class_sampleDimension * fix unit definition identifiers in test cases * fix attributeGroup test data * Refactor algorithm element to LE_Processing in 19115_3_leProcessStep.xml and 19115_3_processing.xml * Refactor algorithm element to LE_Processing in 19115_3_processing.xml * Remove underscore from id's in iso19115-3 writer tests * Update organization external identifier namespace from ORCID to ROR Remove duplicate external contact identifier in iso19115-3 writer * Update to ROR on feature xml and proper capitalization of multiPoint * Removed partyIdentifier duplicate in expected organization output * Remove duplicate partyIdentifier in expected constraintCommon xml * Fix Spacing * Fix spacing and remove duplicate partyIdentifier in expected constraintCommon xml --------- Co-authored-by: Johnathan Aspinwall <[email protected]> Co-authored-by: Jonathan Oliveros <[email protected]> * Fix version comparison bug in mdJson_reader.rb (#356) * Fix version comparison bug in mdJson_reader.rb * Fix version comparison logic * Update adiwg-mdtranslator version to 2.20.0-beta.0 * Update adiwg-mdtranslator version to 2.19.0-beta.8 --------- Co-authored-by: J-Oliveros <[email protected]> Co-authored-by: Chris MacDermaid <[email protected]> Co-authored-by: Jonathan Oliveros <[email protected]> * Update adiwg-mdjson_schemas and adiwg-mdcodes gem dependencies * Update adiwg-mdtranslator version to 2.20.0-beta.1 * Update adiwg-mdcodes gem dependency to version 2.9.3.pre.beta.3 * Update adiwg-mdjson_schemas gem dependency to version 2.9.2.pre.beta.19 * Update mdtranslator version to 2.19.0-beta.9 * Update adiwg-mdtranslator version to 2.19.0.pre.beta.9 * Fix data quality report type * Update adiwg-mdtranslator version to 2.19.0.pre.beta.10 * Update adiwg-mdtranslator version to 2.20.0.pre.beta.1 * Fix evaluationMethodType in class_dataQualityReport.rb * Update adiwg-mdtranslator version to 2.20.0-beta.0 * Update adiwg-mdjson_schemas and adiwg-mdcodes gem dependencies to latest versions * Update adiwg-mdtranslator version to 2.19.0.pre.beta.11 * Update adiwg-mdtranslator and adiwg-mdjson_schemas gem dependencies to latest versions * Fix evaluationMethodType in class_dataQualityReport.rb * Fix data quality report type * Update adiwg-mdtranslator version to 2.19.0.pre.beta.13 * Update adiwg-mdtranslator and adiwg-mdjson_schemas gem dependencies to latest versions * Update adiwg-mdtranslator and adiwg-mdjson_schemas gem dependencies to latest versions * Update adiwg-mdtranslator and adiwg-mdjson_schemas gem dependencies to latest versions * Fix data quality report type * Fix data quality report type * Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.15 * chore: Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.15 * Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.16 * Update module files to include 'name' attribute * Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.17 * Add bureauCode class to DCAT writer (#379) * Add bureauCode class to DCAT writer * Update logic in BureauCode. Add ProgramCode class and update references in dcat_us class * chore: Update adiwg-mdtranslator and adiwg-mdjson_schemas gem dependencies to latest versions * Update adiwg-mdtranslator and adiwg-mdjson_schemas gem dependencies to latest versions * Fix data quality report summary display * Refactor data quality report type display * Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.18 * Refactor mdJson_onlineResource module to include 'protocol' attribute * Refactor mdJson_resourceInfo module to include 'credit' attribute * Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.18 * Refactor data quality report type display * chore: Update versions mdJson-schemas to v2.9.3-beta.3 mdCodes to v2.9.4-beta.4 * chore: Increment beta version * Revert Data Quality Report Types * Refactor sbJson_citation.rb 1. If the user provided Other Cit Details, then use that 2. If Other Cit Details is null, then provide a basic citation of: author1, author2, ..., Citation Title * Refactor data quality report type display and add system identifier support * Refactor data quality report logic handling * Refactor data quality reports * Refactor data quality reports * chore: Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.21 * Refactor data quality reports * chore: Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.22 * Refactor XML date format in test data files * Refactor data identification to handle distribution liability statements * chore: Update adiwg-mdtranslator gem dependency to version 2.20.0.pre.beta.4 * chore: Update adiwg-mdtranslator gem dependency to version 2.10.0.pre.beta.3 * chore: Update adiwg-mdtranslator gem dependency to version 2.20.0.pre.beta.5 * chore: Update adiwg-mdtranslator gem dependency to version 2.19.0.pre.beta.25 * chore: Update adiwg-mdtranslator gem dependency to version 2.10.0 * chore: Update adiwg-mdtranslator gem dependency to version 2.21.0.pre.beta.0 * chore: Update adiwg-mdtranslator gem dependency to version 2.20.0.pre.beta.5 * Update adiwg-mdtranslator gem dependency to version 2.19.0 * Add 'Attribute Accuracy Explanation' text in the evaluation method name field for data quality. * Refactor data quality reports to handle multiple results and different report types * Fix altmax to use maximumAltitude * Refactor Positional Accuracy Reports * fix: Unit test for maximum altitude * Refactor unit test for positional accuracy * feat: Add metadata extension section for taxonomy info. * feat: Set conditional for metadata extension taxonomy. * feat: Remove metadata extension for taxonomy information * Fix: Replaced div with h5 as needed * fix: Citation Other Details * Refactor class_timePeriod.rb for improved date handling * chore: Add note to move object out of function * chore: Refactor unit tests to match modifications to dateTime in timePeriod * chore: Update mdtranslator version to 2.19.0-beta.31 * chore: Update adiwg-mdtranslator version to 2.19.0.pre.beta.31 --------- Co-authored-by: Jonathan Oliveros <[email protected]> Co-authored-by: J-Oliveros <[email protected]> Co-authored-by: James Brown <[email protected]> Co-authored-by: Chris MacDermaid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.