Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifications for pg16 but not enough #27

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Conversation

PerikAdjust
Copy link
Contributor

@PerikAdjust PerikAdjust commented Mar 27, 2024

Start of some modifications to past pg16 test but still doesn't work:

I continue to investigate to find solution but I do not see anything corresponding with the error in pg16 changelog.

  • I started to do some needed change
#if PG_VERSION_NUM >= 160000
#include "varatt.h"
#endif

I also changed ltree.h with the delete of the use of function DatumGetPointer (after look at the different errors), I also do some test so I'm not sure that's useful. That why I keep the previous version commented.

FYI: with docker act to test locally the workflow, each test past except:
CI / 🐘 PostgreSQL 16 (pull_request)

@PerikAdjust PerikAdjust requested a review from a team March 27, 2024 13:05
@ridvankorkmaz
Copy link
Contributor

Hey @za-arthur can you have a look here please? It does not pass test for pg16

@PerikAdjust PerikAdjust merged commit 494ff0b into master Aug 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants