Bugfix V3.0.2 #222
Bugfix V3.0.2 #222
Conversation
|
Repeating comment #202 (comment):
|
|
Repeating #202 (comment):
|
Co-authored-by: sebbader-sap <[email protected]>
|
Closes #191 |
* remove "submodelElements" from SubmodelValue * Update Part2-API-Schemas/openapi.yaml
* change servicedescription/profiles enum to an open list, providing predefined values only as examples
* remove the Level modifier from $metadata requests * remove allOf SubmodelElementAttributes from SubmodelElementMetadata
add array<pathitem> where missing + new pathitem regex
|
@sebbader-sap shouldn't we remove this PR? In the end we will make a PR from IDTA-01001_preparation to main. For V3.0.2 we first need to do the changes in IDTA-01002_preparation as well. Otherwise, no real review is possible. |
|
Depends on #289 |
@BirgitBoss there is no other preparation branch for the V3.0.2 bugfix, only this one. As soon as #288 is approved and merged, we can merge this PR, and by that finish the bugfix. |
AssetAdministrationShellRepositoryServiceSpecification/V3.0_SSP-001.yaml
Show resolved
Hide resolved
AssetAdministrationShellRepositoryServiceSpecification/V3.0_SSP-001.yaml
Show resolved
Hide resolved
AssetAdministrationShellRepositoryServiceSpecification/V3.0_SSP-001.yaml
Show resolved
Hide resolved
| @@ -566,7 +551,7 @@ components: | |||
| aasIds: | |||
| items: | |||
| type: string | |||
| pattern: "^[\\x09\\x0A\\x0D\\x20-\\uD7FF\\uE000-\\uFFFD\\U00010000-\\U0010FFFF]*$" | |||
| pattern: "^([\\x09\\x0a\\x0d\\x20-\\ud7ff\\ue000-\\ufffd]|\\ud800[\\udc00-\\udfff]|[\\ud801-\\udbfe][\\udc00-\\udfff]|\\udbff[\\udc00-\\udfff])*$" | |||
There was a problem hiding this comment.
Is that really required to allow tab, line feed and carriage return (newline) for an id?
There was a problem hiding this comment.
It's what the metamodel defines, therefore, we have to use exactly this pattern...
There was a problem hiding this comment.
We wanted to support IRI, does IRI allow tab, line feed and carriage return (newline)?
| oneOf: | ||
| - $ref: "#/components/schemas/StringValue" | ||
| - $ref: "#/components/schemas/NumberValue" | ||
| - $ref: "#/components/schemas/BooleanValue" |
There was a problem hiding this comment.
In case of date range it could help to be more precise and define a DateValue:
DateValue:
type: string
format: date-time
Without that every date format could be used and would be be not interoperable.
There was a problem hiding this comment.
Hi Sven, this would be a topic for https://github.com/admin-shell-io/aas-specs and then also for the next minor (major?) release version. Therefore, we won't change it in this PR.
There was a problem hiding this comment.
I am not sure this would be backward compatible to include it in V3.1 but I added a corresponding issue: admin-shell-io/aas-specs#444
There was a problem hiding this comment.
The addition of string was part of the API bugfix für ValueOnly, it was not there before, only numerical. So it would be possible to also add DateValue as part of the bugfix.
add changes from the part 1 v3.0.1 json schema
|
@BirgitBoss @waltersve please have a look again. I have incorporated your comments as much as they were still valid for the current state. It looks like some of the comments have been overruled by #289 , at least that's the only way how I can explain the inconsistent state of comments and what is on the branch... |
Successor of #202